Fix crash when create dispatch is failed 93/212993/1 accepted/tizen/unified/20190830.040814 submit/tizen/20190829.112508
authorJeongmo Yang <jm80.yang@samsung.com>
Thu, 29 Aug 2019 06:35:37 +0000 (15:35 +0900)
committerJeongmo Yang <jm80.yang@samsung.com>
Thu, 29 Aug 2019 06:37:40 +0000 (15:37 +0900)
- The mutex is unlocked again after unlocked properly.

[Version] 0.3.87
[Profile] Common
[Issue Type] Bug fix

Change-Id: I352fb09b18cebefa07a413c0e2f2817c170454c6
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
packaging/mused.spec
server/src/muse_server_ipc.c

index f0a8f67..6914cfb 100644 (file)
@@ -1,6 +1,6 @@
 Name:       mused
 Summary:    A multimedia daemon
-Version:    0.3.86
+Version:    0.3.87
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0 and BSD-3-Clause
index 95acba8..84e85c4 100644 (file)
@@ -175,7 +175,6 @@ static gboolean _ms_ipc_dispatch_create(muse_module_h m, void *jobj)
 
        LOGD("module fd: %d dll_handle: %p", m->ch[MUSE_CHANNEL_MSG].sock_fd, m->ch[MUSE_CHANNEL_MSG].dll_handle);
        dispatch_ret = ms_module_dispatch(m);
-       ms_module_dispatch_unlock(m);
 
        if (dispatch_ret != MM_ERROR_NONE) {
                LOGE("create dispatch failed 0x%x, clean up module", dispatch_ret);
@@ -184,10 +183,11 @@ static gboolean _ms_ipc_dispatch_create(muse_module_h m, void *jobj)
 
        m->is_created = TRUE;
 
+       ms_module_dispatch_unlock(m);
+
        return TRUE;
 
 out:
-
        ms_module_dispatch_unlock(m);
 
        return FALSE;