i2c: xiic: Fix the type check for xiic_wakeup
authorShubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Tue, 14 Jun 2022 06:18:55 +0000 (11:48 +0530)
committerWolfram Sang <wsa@kernel.org>
Tue, 14 Jun 2022 20:09:50 +0000 (22:09 +0200)
Fix the coverity warning
mixed_enum_type: enumerated type mixed with another type

We are passing an enum in the xiic_wakeup lets change
the function parameters to reflect that.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Acked-by: Michal Simek <michal.simek@amd.com>
[wsa: fixed $subject with proper prefix]
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-xiic.c

index 9a1c3f8..b3fe6b2 100644 (file)
@@ -367,7 +367,7 @@ static void xiic_fill_tx_fifo(struct xiic_i2c *i2c)
        }
 }
 
-static void xiic_wakeup(struct xiic_i2c *i2c, int code)
+static void xiic_wakeup(struct xiic_i2c *i2c, enum xilinx_i2c_state code)
 {
        i2c->tx_msg = NULL;
        i2c->rx_msg = NULL;
@@ -383,7 +383,7 @@ static irqreturn_t xiic_process(int irq, void *dev_id)
        u32 clr = 0;
        int xfer_more = 0;
        int wakeup_req = 0;
-       int wakeup_code = 0;
+       enum xilinx_i2c_state wakeup_code = STATE_DONE;
        int ret;
 
        /* Get the interrupt Status from the IPIF. There is no clearing of