tty: serial: Samsung: Fix return value
authorSachin Kamat <sachin.kamat@linaro.org>
Wed, 12 Sep 2012 06:30:01 +0000 (12:00 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Sep 2012 11:45:30 +0000 (04:45 -0700)
Return the value returned by the failing function instead
of -1 (which does not convey the right error information).

Fixes the following smatch warning:
drivers/tty/serial/samsung.c:1687 s3c24xx_serial_modinit() info:
why not propagate 'ret' from uart_register_driver() instead of -1?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/samsung.c

index bdaa06f..8eef114 100644 (file)
@@ -1684,7 +1684,7 @@ static int __init s3c24xx_serial_modinit(void)
        ret = uart_register_driver(&s3c24xx_uart_drv);
        if (ret < 0) {
                pr_err("Failed to register Samsung UART driver\n");
-               return -1;
+               return ret;
        }
 
        return platform_driver_register(&samsung_serial_driver);