usb: host: ohci-spear: simplify calling usb_add_hcd()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Mon, 12 Jul 2021 18:16:07 +0000 (21:16 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Jul 2021 08:05:05 +0000 (10:05 +0200)
There is no need to call platform_get_irq() when the driver's probe()
method calls usb_add_hcd() -- the platform_get_irq()'s result will have
been stored already in the 'irq' local variable...

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/3e4ad969-f2ae-32f7-53fd-ea369f140703@omp.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ohci-spear.c

index 5cc0544..b4cd9e6 100644 (file)
@@ -84,7 +84,7 @@ static int spear_ohci_hcd_drv_probe(struct platform_device *pdev)
 
        clk_prepare_enable(sohci_p->clk);
 
-       retval = usb_add_hcd(hcd, platform_get_irq(pdev, 0), 0);
+       retval = usb_add_hcd(hcd, irq, 0);
        if (retval == 0) {
                device_wakeup_enable(hcd->self.controller);
                return retval;