ionic_lif: Use devm_kcalloc() in ionic_qcq_alloc()
authorXu Wang <vulab@iscas.ac.cn>
Mon, 10 Aug 2020 02:38:07 +0000 (02:38 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 11 Aug 2020 17:36:08 +0000 (10:36 -0700)
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pensando/ionic/ionic_lif.c

index 1944bf5..26988ad 100644 (file)
@@ -412,7 +412,7 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type,
 
        new->flags = flags;
 
-       new->q.info = devm_kzalloc(dev, sizeof(*new->q.info) * num_descs,
+       new->q.info = devm_kcalloc(dev, num_descs, sizeof(*new->q.info),
                                   GFP_KERNEL);
        if (!new->q.info) {
                netdev_err(lif->netdev, "Cannot allocate queue info\n");
@@ -462,7 +462,7 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type,
                new->intr.index = IONIC_INTR_INDEX_NOT_ASSIGNED;
        }
 
-       new->cq.info = devm_kzalloc(dev, sizeof(*new->cq.info) * num_descs,
+       new->cq.info = devm_kcalloc(dev, num_descs, sizeof(*new->cq.info),
                                    GFP_KERNEL);
        if (!new->cq.info) {
                netdev_err(lif->netdev, "Cannot allocate completion queue info\n");