chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84b...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Sep 2011 23:24:17 +0000 (23:24 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Sep 2011 23:24:17 +0000 (23:24 +0000)
https://bugs.webkit.org/show_bug.cgi?id=51639

Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-23
Reviewed by Tony Chang.

Add repro for a crash inside WebCore::ApplyStyleCommand::applyBlockStyle. Fixed by r94840.

* editing/style/justify-without-enclosing-block-expected.txt: Added.
* editing/style/justify-without-enclosing-block.xhtml: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/editing/style/justify-without-enclosing-block-expected.txt [new file with mode: 0644]
LayoutTests/editing/style/justify-without-enclosing-block.xhtml [new file with mode: 0644]

index 083d54a..decdeba 100644 (file)
@@ -1,3 +1,15 @@
+2011-09-23  Jay Soffian  <jaysoffian@gmail.com>
+
+        chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
+        https://bugs.webkit.org/show_bug.cgi?id=51639
+
+        Reviewed by Tony Chang.
+
+        Add repro for a crash inside WebCore::ApplyStyleCommand::applyBlockStyle. Fixed by r94840.
+
+        * editing/style/justify-without-enclosing-block-expected.txt: Added.
+        * editing/style/justify-without-enclosing-block.xhtml: Added.
+
 2011-09-23  Adam Barth  <abarth@webkit.org>
 
         Note flaky test.
diff --git a/LayoutTests/editing/style/justify-without-enclosing-block-expected.txt b/LayoutTests/editing/style/justify-without-enclosing-block-expected.txt
new file mode 100644 (file)
index 0000000..9159459
--- /dev/null
@@ -0,0 +1,5 @@
+execCommand("JustifyNone") was crashing inside WebCore::ApplyStyleCommand::applyBlockStyle.
+See https://bugs.webkit.org/show_bug.cgi?id=51639
+The test has passed if it does not crash.
+
+PASS
diff --git a/LayoutTests/editing/style/justify-without-enclosing-block.xhtml b/LayoutTests/editing/style/justify-without-enclosing-block.xhtml
new file mode 100644 (file)
index 0000000..18dca57
--- /dev/null
@@ -0,0 +1,25 @@
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <style>
+      *{
+        /* Note: applying a text-decoration to the body is necessary to
+         * cause the crash, as is having the document parsed as xhtml. 
+         */
+        text-decoration:underline;
+      }
+    </style>
+    <script>
+      function go() {
+        document.execCommand("SelectAll");
+        document.execCommand("JustifyRight");
+        document.execCommand("JustifyNone");
+      }
+    </script>
+  </head>
+  <body onload="go()" contenteditable="true">
+    execCommand("JustifyNone") was crashing inside WebCore::ApplyStyleCommand::applyBlockStyle.<br/>
+    See https://bugs.webkit.org/show_bug.cgi?id=51639<br/>
+    The test has passed if it does not crash.<br/><br/>
+    PASS
+  </body>
+</html>
\ No newline at end of file