plugins/elements/gstbufferstore.c

Original commit message from CVS:
2005-12-16  Andy Wingo  <wingo@pobox.com>

* plugins/elements/gstbufferstore.c
(gst_buffer_store_cleared_func): Pay attention to g_list_append
return value.

* tests/check/gst/gstobject.c
(test_fake_object_name_threaded_unique): Pay attention to
g_list_sort return value.

diff --git a/ChangeLog b/ChangeLog
index 06c2d29..d86b360 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2005-12-16  Andy Wingo  <wingo@pobox.com>
+
+       * plugins/elements/gstbufferstore.c
+       (gst_buffer_store_cleared_func): Pay attention to g_list_append
+       return value.
+
+       * tests/check/gst/gstobject.c
+       (test_fake_object_name_threaded_unique): Pay attention to
+       g_list_sort return value.
+
 2005-12-16  Tim-Philipp Müller  <tim at centricular dot net>
 
        * tools/gst-feedback-m.m:

diff --git a/plugins/elements/gstbufferstore.c b/plugins/elements/gstbufferstore.c
index 492f64a..dea5419 100644 (file)
--- a/plugins/elements/gstbufferstore.c
+++ b/plugins/elements/gstbufferstore.c
@@ -233,7 +233,7 @@ gst_buffer_store_add_buffer_func (GstBufferStore * store, GstBuffer * buffer)
           "adding buffer %p with offset %" G_GINT64_FORMAT " and size %u",
           buffer, GST_BUFFER_OFFSET (buffer), GST_BUFFER_SIZE (buffer));
       if (current_list) {
-        g_list_append (current_list, buffer);
+        current_list = g_list_append (current_list, buffer);
       } else {
         g_assert (store->buffers == NULL);
         store->buffers = g_list_prepend (NULL, buffer);

diff --git a/tests/check/gst/gstobject.c b/tests/check/gst/gstobject.c
index 4afd5bd..dc5ec1b 100644 (file)
--- a/tests/check/gst/gstobject.c
+++ b/tests/check/gst/gstobject.c
@@ -311,7 +311,8 @@ GST_START_TEST (test_fake_object_name_threaded_unique)
 
   /* sort GList based on object name */
   /* FIXME: sort and test */
-  g_list_sort (object_list, (GCompareFunc) gst_object_name_compare);
+  object_list =
+      g_list_sort (object_list, (GCompareFunc) gst_object_name_compare);
 
   name1 = gst_object_get_name (GST_OBJECT (object_list->data));
   for (l = object_list->next; l->next; l = l->next) {