qed: remove redundant assignments to rc

The variable rc is assigned with a value that is never read and
it is re-assigned a new value later on.  The assignment is redundant
and can be removed.  Clean up multiple occurrances of this pattern.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
index 7e0b795230b2b0c95f0704027f5dbf5613f6ee12..900bc603e30a1195ec3d8b111d43b8168f27c9d3 100644 (file)
--- a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
@@ -331,8 +331,8 @@ int qed_sp_pf_start(struct qed_hwfn *p_hwfn,
        u8 sb_index = p_hwfn->p_eq->eq_sb_index;
        struct qed_spq_entry *p_ent = NULL;
        struct qed_sp_init_data init_data;
-       int rc = -EINVAL;
        u8 page_cnt, i;
+       int rc;
 
        /* update initial eq producer */
        qed_eq_prod_update(p_hwfn,
@@ -447,7 +447,7 @@ int qed_sp_pf_update(struct qed_hwfn *p_hwfn)
 {
        struct qed_spq_entry *p_ent = NULL;
        struct qed_sp_init_data init_data;
-       int rc = -EINVAL;
+       int rc;
 
        /* Get SPQ entry */
        memset(&init_data, 0, sizeof(init_data));
@@ -471,7 +471,7 @@ int qed_sp_pf_update_ufp(struct qed_hwfn *p_hwfn)
 {
        struct qed_spq_entry *p_ent = NULL;
        struct qed_sp_init_data init_data;
-       int rc = -EOPNOTSUPP;
+       int rc;
 
        if (p_hwfn->ufp_info.pri_type == QED_UFP_PRI_UNKNOWN) {
                DP_INFO(p_hwfn, "Invalid priority type %d\n",
@@ -509,7 +509,7 @@ int qed_sp_pf_update_tunn_cfg(struct qed_hwfn *p_hwfn,
 {
        struct qed_spq_entry *p_ent = NULL;
        struct qed_sp_init_data init_data;
-       int rc = -EINVAL;
+       int rc;
 
        if (IS_VF(p_hwfn->cdev))
                return qed_vf_pf_tunnel_param_update(p_hwfn, p_tunn);
@@ -546,7 +546,7 @@ int qed_sp_pf_stop(struct qed_hwfn *p_hwfn)
 {
        struct qed_spq_entry *p_ent = NULL;
        struct qed_sp_init_data init_data;
-       int rc = -EINVAL;
+       int rc;
 
        /* Get SPQ entry */
        memset(&init_data, 0, sizeof(init_data));