platform/x86: intel: int1092: intel_sar: Convert to platform remove callback returnin...

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230302144732.1903781-21-u.kleine-koenig@pengutronix.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/intel/int1092/intel_sar.c b/drivers/platform/x86/intel/int1092/intel_sar.c
index 352fc45964946960474b3477d722ef90b283365c..6246c066ade2bc4167f1bb83a06546f4f3767ceb 100644 (file)
--- a/drivers/platform/x86/intel/int1092/intel_sar.c
+++ b/drivers/platform/x86/intel/int1092/intel_sar.c
@@ -292,7 +292,7 @@ r_free:
        return result;
 }
 
-static int sar_remove(struct platform_device *device)
+static void sar_remove(struct platform_device *device)
 {
        struct wwan_sar_context *context = dev_get_drvdata(&device->dev);
        int reg;
@@ -304,12 +304,11 @@ static int sar_remove(struct platform_device *device)
                kfree(context->config_data[reg].device_mode_info);
 
        kfree(context);
-       return 0;
 }
 
 static struct platform_driver sar_driver = {
        .probe = sar_probe,
-       .remove = sar_remove,
+       .remove_new = sar_remove,
        .driver = {
                .name = DRVNAME,
                .acpi_match_table = ACPI_PTR(sar_device_ids)