ASoC: rt5682: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 21:25:25 +0000 (15:25 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:10:13 +0000 (13:10 +0000)
cppcheck warning:

sound/soc/codecs/rt5682.c:2401:65: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
      (pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT |

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-23-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5682.c

index b306ac4..e454220 100644 (file)
@@ -2396,10 +2396,10 @@ static int rt5682_set_component_pll(struct snd_soc_component *component,
                        pll_code.n_code, pll_code.k_code);
 
                snd_soc_component_write(component, RT5682_PLL_CTRL_1,
-                       pll_code.n_code << RT5682_PLL_N_SFT | pll_code.k_code);
+                       (pll_code.n_code << RT5682_PLL_N_SFT) | pll_code.k_code);
                snd_soc_component_write(component, RT5682_PLL_CTRL_2,
-                   (pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT |
-                   pll_code.m_bp << RT5682_PLL_M_BP_SFT | RT5682_PLL_RST);
+                       ((pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT) |
+                       (pll_code.m_bp << RT5682_PLL_M_BP_SFT | RT5682_PLL_RST));
        }
 
        rt5682->pll_in[pll_id] = freq_in;