Disable PDF in dm for tonight. It's crashy.

BUG=skia:2598
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/317533003

diff --git a/dm/DMPDFTask.cpp b/dm/DMPDFTask.cpp
index 270f4b4..e50e9ec 100644 (file)
--- a/dm/DMPDFTask.cpp
+++ b/dm/DMPDFTask.cpp
@@ -13,7 +13,11 @@
 #include "SkCommandLineFlags.h"
 #include "SkDocument.h"
 
-DEFINE_bool(pdf, true, "PDF backend master switch.");
+// The PDF backend is not threadsafe.  If you run dm with --pdf repeatedly, you
+// will quickly find yourself crashed.  (while catchsegv out/Release/dm;; end).
+//
+// TODO(mtklein): re-enable by default, maybe moving to its own single thread.
+DEFINE_bool(pdf, false, "PDF backend master switch.");
 
 namespace DM {