crypto: omap-sham - Use pm_runtime_put instead of pm_runtime_put_sync in tasklet
authorJoel A Fernandes <joelagnel@ti.com>
Tue, 26 Feb 2013 16:04:31 +0000 (10:04 -0600)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 10 Mar 2013 08:46:44 +0000 (16:46 +0800)
After DMA is complete, the omap_sham_finish_req function is called as
a part of the done_task tasklet. During this its atomic and any calls
to pm functions should not assume they wont sleep.

The patch replaces a call to pm_runtime_put_sync (which can sleep) with
pm_runtime_put thus fixing a kernel panic observed on AM33xx SoC during
SHA operation.

Tested on an AM33xx SoC device (beaglebone board).
To reproduce the problem, used the tcrypt kernel module as:
modprobe tcrypt sec=2 mode=403

Signed-off-by: Joel A Fernandes <joelagnel@ti.com>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: Mark A. Greer <mgreer@animalcreek.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-sham.c

index 3d1611f..1cfdea1 100644 (file)
@@ -923,7 +923,7 @@ static void omap_sham_finish_req(struct ahash_request *req, int err)
        dd->flags &= ~(BIT(FLAGS_BUSY) | BIT(FLAGS_FINAL) | BIT(FLAGS_CPU) |
                        BIT(FLAGS_DMA_READY) | BIT(FLAGS_OUTPUT_READY));
 
-       pm_runtime_put_sync(dd->dev);
+       pm_runtime_put(dd->dev);
 
        if (req->base.complete)
                req->base.complete(&req->base, err);