leds: is31fl32xx: Fix missing error code in is31fl32xx_parse_dt()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Tue, 1 Jun 2021 11:09:03 +0000 (19:09 +0800)
committerPavel Machek <pavel@ucw.cz>
Mon, 12 Jul 2021 08:30:07 +0000 (10:30 +0200)
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing
error code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")
Acked-by: David Rivshin <drivshin@allworx.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-is31fl32xx.c

index 3b55af9..22c092a 100644 (file)
@@ -386,6 +386,7 @@ static int is31fl32xx_parse_dt(struct device *dev,
                        dev_err(dev,
                                "Node %pOF 'reg' conflicts with another LED\n",
                                child);
+                       ret = -EINVAL;
                        goto err;
                }