media: coda: Handle return value of kasprintf
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Wed, 20 Sep 2017 09:40:58 +0000 (11:40 +0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 27 Oct 2017 12:09:39 +0000 (14:09 +0200)
kasprintf() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/coda/coda-bit.c

index 291c409..bfc4ecf 100644 (file)
@@ -417,6 +417,10 @@ static int coda_alloc_framebuffers(struct coda_ctx *ctx,
                    dev->devtype->product != CODA_DX6)
                        size += ysize / 4;
                name = kasprintf(GFP_KERNEL, "fb%d", i);
+               if (!name) {
+                       coda_free_framebuffers(ctx);
+                       return -ENOMEM;
+               }
                ret = coda_alloc_context_buf(ctx, &ctx->internal_frames[i],
                                             size, name);
                kfree(name);