HTMLIsIndexElement should not expose HTMLInputElement properties
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Jan 2012 00:17:59 +0000 (00:17 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Jan 2012 00:17:59 +0000 (00:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=76095

Reviewed by Adam Barth.

Source/WebCore:

document.createElement("isindex") should produce an HTMLUnknownElement
per the HTML5 spec.  The parser automagically translates <isindex> into
a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)

This patch just removes our support for HTMLIsIndexElement.  The parser
support was already in.  Having support for HTMLIsIndexElement was causing
one of the IE TestCenter tests to fail.

Test: fast/dom/HTMLIsIndexElement/prototype-chain.html

* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/GNUmakefile.am:
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
(WebKit::createHTMLElementWrapper):
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
* bindings/objc/DOMHTML.h:
* bindings/objc/PublicDOMInterfaces.h:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLIsIndexElement.cpp: Removed.
* html/HTMLIsIndexElement.h: Removed.
* html/HTMLIsIndexElement.idl: Removed.
* html/HTMLTagNames.in:
* page/DOMWindow.idl:

Source/WebKit/mac:

* MigrateHeaders.make:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/DerivedSources.cpp
Source/WebCore/DerivedSources.make
Source/WebCore/DerivedSources.pri
Source/WebKit/mac/ChangeLog

index 9065227..8cb3919 100644 (file)
@@ -1,5 +1,46 @@
 2012-01-25  Eric Seidel  <eric@webkit.org>
 
+        HTMLIsIndexElement should not expose HTMLInputElement properties
+        https://bugs.webkit.org/show_bug.cgi?id=76095
+
+        Reviewed by Adam Barth.
+
+        document.createElement("isindex") should produce an HTMLUnknownElement
+        per the HTML5 spec.  The parser automagically translates <isindex> into
+        a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)
+
+        This patch just removes our support for HTMLIsIndexElement.  The parser
+        support was already in.  Having support for HTMLIsIndexElement was causing
+        one of the IE TestCenter tests to fail.
+
+        Test: fast/dom/HTMLIsIndexElement/prototype-chain.html
+
+        * DerivedSources.cpp:
+        * DerivedSources.make:
+        * DerivedSources.pri:
+        * GNUmakefile.list.am:
+        * Target.pri:
+        * WebCore.exp.in:
+        * WebCore.gypi:
+        * WebCore.order:
+        * WebCore.vcproj/WebCore.vcproj:
+        * WebCore.xcodeproj/project.pbxproj:
+        * bindings/gobject/GNUmakefile.am:
+        * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
+        (WebKit::createHTMLElementWrapper):
+        * bindings/objc/DOM.mm:
+        (WebCore::createElementClassMap):
+        * bindings/objc/DOMHTML.h:
+        * bindings/objc/PublicDOMInterfaces.h:
+        * html/HTMLElementsAllInOne.cpp:
+        * html/HTMLIsIndexElement.cpp: Removed.
+        * html/HTMLIsIndexElement.h: Removed.
+        * html/HTMLIsIndexElement.idl: Removed.
+        * html/HTMLTagNames.in:
+        * page/DOMWindow.idl:
+
+2012-01-25  Eric Seidel  <eric@webkit.org>
+
         HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload
         https://bugs.webkit.org/show_bug.cgi?id=74360
 
index 5fa5e00..2b02361 100644 (file)
 #include "JSHTMLIFrameElement.cpp"
 #include "JSHTMLImageElement.cpp"
 #include "JSHTMLInputElement.cpp"
-#include "JSHTMLIsIndexElement.cpp"
 #include "JSHTMLKeygenElement.cpp"
 #include "JSHTMLLabelElement.cpp"
 #include "JSHTMLLegendElement.cpp"
index 64be83d..500509b 100644 (file)
@@ -215,7 +215,6 @@ BINDING_IDLS = \
     $(WebCore)/html/HTMLIFrameElement.idl \
     $(WebCore)/html/HTMLImageElement.idl \
     $(WebCore)/html/HTMLInputElement.idl \
-    $(WebCore)/html/HTMLIsIndexElement.idl \
     $(WebCore)/html/HTMLKeygenElement.idl \
     $(WebCore)/html/HTMLLIElement.idl \
     $(WebCore)/html/HTMLLabelElement.idl \
index 5b9f0f6..0347090 100644 (file)
@@ -280,7 +280,6 @@ IDL_BINDINGS += \
     $$PWD/html/HTMLIFrameElement.idl \
     $$PWD/html/HTMLImageElement.idl \
     $$PWD/html/HTMLInputElement.idl \
-    $$PWD/html/HTMLIsIndexElement.idl \
     $$PWD/html/HTMLKeygenElement.idl \
     $$PWD/html/HTMLLabelElement.idl \
     $$PWD/html/HTMLLegendElement.idl \
index 589c18e..f09d319 100644 (file)
@@ -1,3 +1,12 @@
+2012-01-25  Eric Seidel  <eric@webkit.org>
+
+        HTMLIsIndexElement should not expose HTMLInputElement properties
+        https://bugs.webkit.org/show_bug.cgi?id=76095
+
+        Reviewed by Adam Barth.
+
+        * MigrateHeaders.make:
+
 2012-01-25  Hajime Morita  <morrita@google.com>
 
         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom