ar5523: Use kzalloc instead of kmalloc/memset
authorHaowen Bai <baihaowen@meizu.com>
Tue, 19 Apr 2022 01:37:31 +0000 (09:37 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 20 Apr 2022 10:04:09 +0000 (11:04 +0100)
Use kzalloc rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireless/ath/ar5523/ar5523.c

index 9cabd34..7527a38 100644 (file)
@@ -1500,7 +1500,7 @@ static int ar5523_load_firmware(struct usb_device *dev)
                return -ENOENT;
        }
 
-       txblock = kmalloc(sizeof(*txblock), GFP_KERNEL);
+       txblock = kzalloc(sizeof(*txblock), GFP_KERNEL);
        if (!txblock)
                goto out;
 
@@ -1512,7 +1512,6 @@ static int ar5523_load_firmware(struct usb_device *dev)
        if (!fwbuf)
                goto out_free_rxblock;
 
-       memset(txblock, 0, sizeof(struct ar5523_fwblock));
        txblock->flags = cpu_to_be32(AR5523_WRITE_BLOCK);
        txblock->total = cpu_to_be32(fw->size);