drm/panfrost: Reduce the amount of logs on deferred probe
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 27 May 2020 20:05:44 +0000 (22:05 +0200)
committerSteven Price <steven.price@arm.com>
Thu, 18 Jun 2020 08:59:25 +0000 (09:59 +0100)
There is no point to print deferred probe (and its failures to get
resources) as an error.  Also there is no need to print regulator errors
twice.

In case of multiple probe tries this would pollute the dmesg.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200527200544.7849-1-krzk@kernel.org
drivers/gpu/drm/panfrost/panfrost_device.c

index 8136babd3ba9935f018fc0ddd8057580220ebe15..b172087eee6ae171af52b5a6e670bb704db69f59 100644 (file)
@@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
                                      pfdev->comp->num_supplies,
                                      pfdev->regulators);
        if (ret < 0) {
-               dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
+               if (ret != -EPROBE_DEFER)
+                       dev_err(pfdev->dev, "failed to get regulators: %d\n",
+                               ret);
                return ret;
        }
 
@@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
        }
 
        err = panfrost_regulator_init(pfdev);
-       if (err) {
-               dev_err(pfdev->dev, "regulator init failed %d\n", err);
+       if (err)
                goto err_out0;
-       }
 
        err = panfrost_reset_init(pfdev);
        if (err) {