Use unreachable post switch rather than default case.

Prefer to enumerate all cases in the switch instead of using default to allow
compiler to flag missing cases. This also avoids -Wcovered-switch-default
warning.

PiperOrigin-RevId: 262935972

diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index 7a84eae..19ff096 100644 (file)
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -135,9 +135,8 @@ static llvm::CmpInst::Predicate getLLVMCmpPredicate(ICmpPredicate p) {
     return llvm::CmpInst::Predicate::ICMP_UGT;
   case LLVM::ICmpPredicate::uge:
     return llvm::CmpInst::Predicate::ICMP_UGE;
-  default:
-    llvm_unreachable("incorrect comparison predicate");
   }
+  llvm_unreachable("incorrect comparison predicate");
 }
 
 static llvm::CmpInst::Predicate getLLVMCmpPredicate(FCmpPredicate p) {
@@ -174,9 +173,8 @@ static llvm::CmpInst::Predicate getLLVMCmpPredicate(FCmpPredicate p) {
     return llvm::CmpInst::Predicate::FCMP_UNO;
   case LLVM::FCmpPredicate::_true:
     return llvm::CmpInst::Predicate::FCMP_TRUE;
-  default:
-    llvm_unreachable("incorrect comparison predicate");
   }
+  llvm_unreachable("incorrect comparison predicate");
 }
 
 // A helper to look up remapped operands in the value remapping table.