perf auxtrace: Factor out itrace_do_parse_synth_opts()
authorAdrian Hunter <adrian.hunter@intel.com>
Sun, 30 May 2021 19:23:03 +0000 (22:23 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 1 Jun 2021 13:04:10 +0000 (10:04 -0300)
Factor out itrace_do_parse_synth_opts() so that it can be reused.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: https://lore.kernel.org/r/20210530192308.7382-9-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/auxtrace.c
tools/perf/util/auxtrace.h

index 62268f8b6c4f42d19ce1152b8f483c293c5cb423..9350eeb3a3fc6f720342b37bd38467b590489a8d 100644 (file)
@@ -1405,10 +1405,9 @@ static int get_flags(const char **ptr, unsigned int *plus_flags, unsigned int *m
  * about the options parsed here, which is introduced after this cset,
  * when support in 'perf script' for these options is introduced.
  */
-int itrace_parse_synth_opts(const struct option *opt, const char *str,
-                           int unset)
+int itrace_do_parse_synth_opts(struct itrace_synth_opts *synth_opts,
+                              const char *str, int unset)
 {
-       struct itrace_synth_opts *synth_opts = opt->value;
        const char *p;
        char *endptr;
        bool period_type_set = false;
@@ -1596,6 +1595,11 @@ out_err:
        return -EINVAL;
 }
 
+int itrace_parse_synth_opts(const struct option *opt, const char *str, int unset)
+{
+       return itrace_do_parse_synth_opts(opt->value, str, unset);
+}
+
 static const char * const auxtrace_error_type_name[] = {
        [PERF_AUXTRACE_ERROR_ITRACE] = "instruction trace",
 };
index 4283a4befcb618f4221648b6fff581ccad3d3a69..efca761e8b84f8d743f259ade353eb8e2aaf834d 100644 (file)
@@ -607,6 +607,8 @@ s64 perf_event__process_auxtrace(struct perf_session *session,
                                 union perf_event *event);
 int perf_event__process_auxtrace_error(struct perf_session *session,
                                       union perf_event *event);
+int itrace_do_parse_synth_opts(struct itrace_synth_opts *synth_opts,
+                              const char *str, int unset);
 int itrace_parse_synth_opts(const struct option *opt, const char *str,
                            int unset);
 void itrace_synth_opts__set_default(struct itrace_synth_opts *synth_opts,
@@ -738,6 +740,14 @@ void events_stats__auxtrace_error_warn(const struct events_stats *stats
 {
 }
 
+static inline
+int itrace_do_parse_synth_opts(struct itrace_synth_opts *synth_opts __maybe_unused,
+                              const char *str __maybe_unused, int unset __maybe_unused)
+{
+       pr_err("AUX area tracing not supported\n");
+       return -EINVAL;
+}
+
 static inline
 int itrace_parse_synth_opts(const struct option *opt __maybe_unused,
                            const char *str __maybe_unused,