mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB
authorFrieder Schrempf <frieder.schrempf@kontron.de>
Mon, 22 Jun 2020 13:16:32 +0000 (16:16 +0300)
committerJagan Teki <jagan@amarulasolutions.com>
Fri, 18 Dec 2020 10:46:36 +0000 (16:16 +0530)
When writing the bad block marker to the OOB area the access mode
should be set to MTD_OPS_RAW as it is done for reading the marker.
Currently this only works because req.mode is initialized to
MTD_OPS_PLACE_OOB (0) and spinand_write_to_cache_op() checks for
req.mode != MTD_OPS_AUTO_OOB.

Fix this by explicitly setting req.mode to MTD_OPS_RAW.

Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200218100432.32433-3-frieder.schrempf@kontron.de
drivers/mtd/nand/spi/core.c

index 77188ec..9ab43d9 100644 (file)
@@ -708,6 +708,7 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos)
                .ooboffs = 0,
                .ooblen = sizeof(marker),
                .oobbuf.out = marker,
+               .mode = MTD_OPS_RAW,
        };
        int ret;