Fix not NULL terminated string

CID-106324

Change-Id: Ia12e2f88c48e1959fc825cb9b1dc64256bb87bad

diff --git a/src/http_common.c b/src/http_common.c
index d749371..5751b6d 100644 (file)
--- a/src/http_common.c
+++ b/src/http_common.c
@@ -50,7 +50,7 @@ bool _http_check_permission(http_privilege_e _privilege)
        FILE *fd;
 
        int ret;
-       char smack_label[SMACK_LABEL_LEN + 1];
+       char smack_label[SMACK_LABEL_LEN + 1] = {0, };
        char uid[10];
        char *client_session = "";
        char *privilege = NULL;
@@ -70,12 +70,14 @@ bool _http_check_permission(http_privilege_e _privilege)
                ERR("Failed to open /proc/self/attr/current\n");
                return false;
        }
-       ret = fread(smack_label, sizeof(smack_label), 1, fd);
-       fclose(fd);
-       if (ret < 0) {
+       ret = fread(smack_label, SMACK_LABEL_LEN, 1, fd);
+
+       if (ferror(fd)) {
                ERR("Failed to read /proc/self/attr/current\n");
+               fclose(fd);
                return false;
        }
+       fclose(fd);
 
        /* get uid */
        snprintf(uid, sizeof(uid), "%d", getuid());