mtd: lpddr_cmds: remove unused words variable
authorTom Rix <trix@redhat.com>
Tue, 28 Mar 2023 00:06:20 +0000 (20:06 -0400)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 28 Mar 2023 12:59:21 +0000 (14:59 +0200)
clang with W=1 reports
drivers/mtd/lpddr/lpddr_cmds.c:409:31: error: variable
  'words' set but not used [-Werror,-Wunused-but-set-variable]
        int ret, wbufsize, word_gap, words;
                                     ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20230328000620.1778033-1-trix@redhat.com
drivers/mtd/lpddr/lpddr_cmds.c

index ee063ba..3c3939b 100644 (file)
@@ -406,7 +406,7 @@ static int do_write_buffer(struct map_info *map, struct flchip *chip,
 {
        struct lpddr_private *lpddr = map->fldrv_priv;
        map_word datum;
-       int ret, wbufsize, word_gap, words;
+       int ret, wbufsize, word_gap;
        const struct kvec *vec;
        unsigned long vec_seek;
        unsigned long prog_buf_ofs;
@@ -421,10 +421,7 @@ static int do_write_buffer(struct map_info *map, struct flchip *chip,
        }
        /* Figure out the number of words to write */
        word_gap = (-adr & (map_bankwidth(map)-1));
-       words = (len - word_gap + map_bankwidth(map) - 1) / map_bankwidth(map);
-       if (!word_gap) {
-               words--;
-       } else {
+       if (word_gap) {
                word_gap = map_bankwidth(map) - word_gap;
                adr -= word_gap;
                datum = map_word_ff(map);