media: v4l: cadence: Handle errors of clk_prepare_enable()

Handle errors of clk_prepare_enable() in csi2tx_get_resources().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/platform/cadence/cdns-csi2tx.c b/drivers/media/platform/cadence/cdns-csi2tx.c
index e4d08ac..765ae40 100644 (file)
--- a/drivers/media/platform/cadence/cdns-csi2tx.c
+++ b/drivers/media/platform/cadence/cdns-csi2tx.c
@@ -436,6 +436,7 @@ static int csi2tx_get_resources(struct csi2tx_priv *csi2tx,
        struct resource *res;
        unsigned int i;
        u32 dev_cfg;
+       int ret;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        csi2tx->base = devm_ioremap_resource(&pdev->dev, res);
@@ -454,7 +455,12 @@ static int csi2tx_get_resources(struct csi2tx_priv *csi2tx,
                return PTR_ERR(csi2tx->esc_clk);
        }
 
-       clk_prepare_enable(csi2tx->p_clk);
+       ret = clk_prepare_enable(csi2tx->p_clk);
+       if (ret) {
+               dev_err(&pdev->dev, "Couldn't prepare and enable p_clk\n");
+               return ret;
+       }
+
        dev_cfg = readl(csi2tx->base + CSI2TX_DEVICE_CONFIG_REG);
        clk_disable_unprepare(csi2tx->p_clk);