selinux: add missing newlines in pr_err() statements
authorChristian Göttsche <cgzones@googlemail.com>
Tue, 18 Jul 2023 19:00:24 +0000 (21:00 +0200)
committerPaul Moore <paul@paul-moore.com>
Wed, 19 Jul 2023 15:12:48 +0000 (11:12 -0400)
The kernel print statements do not append an implicit newline to format
strings.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
[PM: subject line tweak]
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/hooks.c
security/selinux/ss/policydb.c

index 9aa60ce..dc51f28 100644 (file)
@@ -2930,7 +2930,7 @@ static int selinux_inode_init_security_anon(struct inode *inode,
                struct inode_security_struct *context_isec =
                        selinux_inode(context_inode);
                if (context_isec->initialized != LABEL_INITIALIZED) {
-                       pr_err("SELinux:  context_inode is not initialized");
+                       pr_err("SELinux:  context_inode is not initialized\n");
                        return -EACCES;
                }
 
index cfe77ef..61e0e50 100644 (file)
@@ -1687,7 +1687,7 @@ static int user_bounds_sanity_check(void *key, void *datum, void *datap)
 
                if (++depth == POLICYDB_BOUNDS_MAXDEPTH) {
                        pr_err("SELinux: user %s: "
-                              "too deep or looped boundary",
+                              "too deep or looped boundary\n",
                               (char *) key);
                        return -EINVAL;
                }
@@ -1766,7 +1766,7 @@ static int type_bounds_sanity_check(void *key, void *datum, void *datap)
 
                if (upper->attribute) {
                        pr_err("SELinux: type %s: "
-                              "bounded by attribute %s",
+                              "bounded by attribute %s\n",
                               (char *) key,
                               sym_name(p, SYM_TYPES, upper->value - 1));
                        return -EINVAL;
@@ -3675,7 +3675,7 @@ int policydb_write(struct policydb *p, void *fp)
        info = policydb_lookup_compat(p->policyvers);
        if (!info) {
                pr_err("SELinux: compatibility lookup failed for policy "
-                   "version %d", p->policyvers);
+                   "version %d\n", p->policyvers);
                return -EINVAL;
        }