tests: fix test-shell init error path
authorPekka Paalanen <pekka.paalanen@collabora.com>
Wed, 6 Nov 2019 10:07:23 +0000 (12:07 +0200)
committerDaniel Stone <daniel@fooishbar.org>
Thu, 21 Nov 2019 16:32:55 +0000 (16:32 +0000)
This was forgetting to remove the compositor destroy listener if init failed,
which would lead to use-after-free on compositor tear-down. Found by
inspection.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
tests/weston-test-desktop-shell.c

index c88455c4009da74539704e5878d64bae16ea7b34..ac0ece7b657c17d07b855ab7a82ecf18ab7a7956 100644 (file)
@@ -224,6 +224,7 @@ out_surface:
        weston_surface_destroy(dts->background_surface);
 
 out_free:
+       wl_list_remove(&dts->compositor_destroy_listener.link);
        free(dts);
 
        return -1;