PR c++/21347

	* class.c (maybe_warn_about_overly_private_class): Lazy
	constructors are public.
	PR c++/21347
	* g++.dg/warn/Wctor-dtor.C: New test.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@105441 138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 7b2ff85..51089eb 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2005-10-15  Mark Mitchell  <mark@codesourcery.com>
+
+       PR c++/21347
+       * class.c (maybe_warn_about_overly_private_class): Lazy
+       constructors are public.
+
 2005-10-14  Mark Mitchell  <mark@codesourcery.com>
 
        PR c++/19565

diff --git a/gcc/cp/class.c b/gcc/cp/class.c
index dc52975..b8254fe 100644 (file)
--- a/gcc/cp/class.c
+++ b/gcc/cp/class.c
@@ -1537,7 +1537,10 @@ maybe_warn_about_overly_private_class (tree t)
       return;
     }
 
-  if (TYPE_HAS_CONSTRUCTOR (t))
+  if (TYPE_HAS_CONSTRUCTOR (t)
+      /* Implicitly generated constructors are always public.  */
+      && (!CLASSTYPE_LAZY_DEFAULT_CTOR (t)
+         || !CLASSTYPE_LAZY_COPY_CTOR (t)))
     {
       int nonprivate_ctor = 0;
 

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 04465c5..70f1a0b 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2005-10-15  Mark Mitchell  <mark@codesourcery.com>
+
+       PR c++/21347
+       * g++.dg/warn/Wctor-dtor.C: New test.
+
 2005-10-14  Volker Reichelt  <reichelt@igpm.rwth-aachen.de>
 
        PR c/23439

diff --git a/gcc/testsuite/g++.dg/warn/Wctor-dtor.C b/gcc/testsuite/g++.dg/warn/Wctor-dtor.C
new file mode 100644 (file)
index 0000000..15efb6b
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Wctor-dtor.C
@@ -0,0 +1,13 @@
+// PR c++/21347
+// { dg-options "-Wctor-dtor-privacy" }
+
+class A {
+public:
+  int x;
+  int getX() { return x; } // comment out to avoid warning
+};
+
+int foo() {
+  A a; // accepted: clearly the ctor is not private
+  return a.x;
+}