pan/bi: Assert destinations are non-NULL
authorAlyssa Rosenzweig <alyssa@collabora.com>
Thu, 21 Jul 2022 19:01:16 +0000 (15:01 -0400)
committerMarge Bot <emma+marge@anholt.net>
Fri, 2 Sep 2022 16:03:23 +0000 (16:03 +0000)
All uses of null destinations have been replaced with more appropriate
constructs. We can now assume this throughout.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17794>

src/panfrost/bifrost/bi_validate.c

index 8e7c077..b0c1cb0 100644 (file)
@@ -171,8 +171,8 @@ bi_validate_src_dest_count(bi_context *ctx)
                         }
                 }
 
-                for (unsigned d = I->nr_dests; d < ARRAY_SIZE(I->dest); ++d) {
-                        if (!bi_is_null(I->dest[d])) {
+                for (unsigned d = 0; d < ARRAY_SIZE(I->dest); ++d) {
+                        if ((d < I->nr_dests) == bi_is_null(I->dest[d])) {
                                 succ = false;
                                 fprintf(stderr,
                                         "unexpected dest %u, expected %u sources\n",