drm/vc4: fix argument ordering in vc4_crtc_get_margins()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 21 Apr 2021 10:18:03 +0000 (13:18 +0300)
committerMaxime Ripard <maxime@cerno.tech>
Thu, 29 Apr 2021 10:18:54 +0000 (12:18 +0200)
Cppcheck complains that the declaration doesn't match the function
definition.  Obviously "left" should come before "right".  The caller
and the function implementation are done this way, it's just the
declaration which is wrong so this doesn't affect runtime.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/YH/720FD978TPhHp@mwanda
drivers/gpu/drm/vc4/vc4_drv.h

index a750071..5dceadc 100644 (file)
@@ -825,7 +825,7 @@ void vc4_crtc_destroy_state(struct drm_crtc *crtc,
 void vc4_crtc_reset(struct drm_crtc *crtc);
 void vc4_crtc_handle_vblank(struct vc4_crtc *crtc);
 void vc4_crtc_get_margins(struct drm_crtc_state *state,
-                         unsigned int *right, unsigned int *left,
+                         unsigned int *left, unsigned int *right,
                          unsigned int *top, unsigned int *bottom);
 
 /* vc4_debugfs.c */