mfd: sm5701: Remove build warnings 75/159575/3
authorWook Song <wook16.song@samsung.com>
Fri, 10 Nov 2017 00:38:40 +0000 (09:38 +0900)
committerWook Song <wook16.song@samsung.com>
Fri, 10 Nov 2017 02:31:49 +0000 (11:31 +0900)
This patch removes build warnings caused by non-existent function
argument type, unused function, and wrong printk format strings.

Change-Id: I7ceb213b3326e261e2a7ddeb4fc2e78d1d46db2a
Signed-off-by: Wook Song <wook16.song@samsung.com>
drivers/mfd/sm5701_core.c
drivers/mfd/sm5701_irq.c

index ad7ae9f..e9dff2c 100644 (file)
@@ -254,10 +254,10 @@ int SM5701_operation_mode_function_control(void)
         client = SM5701_core_client;
         pdata = client->dev.platform_data;
                printk("SM5701_operation_mode_function_control\n");
-               printk("client:%x\n", client);
-               printk("client->dev:%x\n", client->dev);
-               printk("pdata = client->dev.platform_data:%x\n", client->dev.platform_data);
-               printk("pdata->charger_data:%x\n", pdata->charger_data);
+               printk("client:%p\n", client);
+               printk("client->dev:%p\n", &(client->dev));
+               printk("pdata = client->dev.platform_data:%p\n", client->dev.platform_data);
+               printk("pdata->charger_data:%p\n", pdata->charger_data);
                printk("pdata->charger_data->cable_type:%x\n", pdata->charger_data->cable_type);
 
         if ((pdata->charger_data->cable_type == POWER_SUPPLY_TYPE_MAINS) ||
index bb0aa63..fcf4e64 100644 (file)
   *\r
   */\r
 #include <linux/module.h>\r
-#include <linux/moduleparam.h> \r
+#include <linux/moduleparam.h>\r
 #include <linux/device.h>\r
 #include <linux/interrupt.h>\r
 #include <linux/irq.h>\r
 #include <linux/mfd/sm5701_core.h>\r
 #include <linux/gpio.h>\r
 \r
-\r
-static irqreturn_t sm5701_irq_thread(int irq, void *data)\r
+static __maybe_unused irqreturn_t sm5701_irq_thread(int irq, void *data)\r
 {\r
-    //printk("******* %s *******\n",__func__);\r
-\r
+       //printk("******* %s *******\n",__func__);\r
        return IRQ_HANDLED;\r
 }\r
 \r
-  \r
-int sm5701_irq_init(struct sm5701_dev *sm5701)\r
-{ \r
-    //printk("******* %s *******\n",__func__);\r
-    \r
-    return 0;\r
-    \r
+int sm5701_irq_init(struct SM5701_dev *sm5701)\r
+{\r
+       //printk("******* %s *******\n",__func__);\r
+       return 0;\r
+\r
 }\r
 EXPORT_SYMBOL(sm5701_irq_init);\r
\r
-void sm5701_irq_exit(struct sm5701_dev *sm5701)\r
+\r
+void sm5701_irq_exit(struct SM5701_dev *sm5701)\r
 {\r
-    //printk("******* %s *******\n",__func__);\r
+       //printk("******* %s *******\n",__func__);\r
 }\r
-EXPORT_SYMBOL(sm5701_irq_exit); \r
+EXPORT_SYMBOL(sm5701_irq_exit);\r