projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c70c453
)
net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
author
Russell King (Oracle)
<rmk+kernel@armlinux.org.uk>
Mon, 7 Mar 2022 12:13:30 +0000
(12:13 +0000)
committer
Paolo Abeni
<pabeni@redhat.com>
Tue, 8 Mar 2022 11:12:25 +0000
(12:12 +0100)
Discussing one of the tests in mt753x_phylink_validate() with Landen
Chao confirms that the "||" should be "&&". Fix this.
Fixes:
c288575f7810
("net: dsa: mt7530: Add the support of MT7531 switch")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link:
https://lore.kernel.org/r/E1nRCF0-00CiXD-7q@rmk-PC.armlinux.org.uk
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/dsa/mt7530.c
patch
|
blob
|
history
diff --git
a/drivers/net/dsa/mt7530.c
b/drivers/net/dsa/mt7530.c
index
ff3c267
..
a251bc5
100644
(file)
--- a/
drivers/net/dsa/mt7530.c
+++ b/
drivers/net/dsa/mt7530.c
@@
-2936,7
+2936,7
@@
mt753x_phylink_validate(struct dsa_switch *ds, int port,
phylink_set_port_modes(mask);
- if (state->interface != PHY_INTERFACE_MODE_TRGMII
||
+ if (state->interface != PHY_INTERFACE_MODE_TRGMII
&&
!phy_interface_mode_is_8023z(state->interface)) {
phylink_set(mask, 10baseT_Half);
phylink_set(mask, 10baseT_Full);