staging: rtl8723bs: core: Prefer using the BIT Macro.
authorVatsala Narang <vatsalanarang@gmail.com>
Wed, 1 May 2019 15:03:44 +0000 (20:33 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 May 2019 16:18:02 +0000 (18:18 +0200)
Replace bit shifting on 1 with the BIT(x) macro.

Issue found using coccinelle.

Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

index d4842ba..d110d45 100644 (file)
@@ -1981,7 +1981,7 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra
                        if (status == 0) {
                                /* successful */
                                DBG_871X("agg_enable for TID =%d\n", tid);
-                               psta->htpriv.agg_enable_bitmap |= 1 << tid;
+                               psta->htpriv.agg_enable_bitmap |= BIT(tid);
                                psta->htpriv.candidate_tid_bitmap &= ~BIT(tid);
                        } else {
                                psta->htpriv.agg_enable_bitmap &= ~BIT(tid);
@@ -1999,8 +1999,10 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra
 
                case RTW_WLAN_ACTION_DELBA: /* DELBA */
                        if ((frame_body[3] & BIT(3)) == 0) {
-                               psta->htpriv.agg_enable_bitmap &= ~(1 << ((frame_body[3] >> 4) & 0xf));
-                               psta->htpriv.candidate_tid_bitmap &= ~(1 << ((frame_body[3] >> 4) & 0xf));
+                               psta->htpriv.agg_enable_bitmap &=
+                                       ~BIT((frame_body[3] >> 4) & 0xf);
+                               psta->htpriv.candidate_tid_bitmap &=
+                                       ~BIT((frame_body[3] >> 4) & 0xf);
 
                                /* reason_code = frame_body[4] | (frame_body[5] << 8); */
                                reason_code = RTW_GET_LE16(&frame_body[4]);