rtpbin: Initialize uninitialized variable correctly
authorSebastian Dröge <sebastian@centricular.com>
Fri, 5 Jun 2020 08:49:17 +0000 (11:49 +0300)
committerSebastian Dröge <sebastian@centricular.com>
Fri, 5 Jun 2020 08:49:17 +0000 (11:49 +0300)
`last_out` would be used uninitialized if the element has no `set-active`
signal. Initialize it to -1 as that's what the "default" value is
further below.

CID 1455443

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/727

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/613>

gst/rtpmanager/gstrtpbin.c

index 6a88b49..6fe786d 100644 (file)
@@ -3219,7 +3219,7 @@ gst_rtp_bin_handle_message (GstBin * bin, GstMessage * message)
                 streams = g_slist_next (streams)) {
               GstRtpBinStream *stream = (GstRtpBinStream *) streams->data;
               GstElement *element = stream->buffer;
-              guint64 last_out;
+              guint64 last_out = -1;
 
               if (g_signal_lookup ("set-active", G_OBJECT_TYPE (element)) != 0) {
                 g_signal_emit_by_name (element, "set-active", active, offset,