PartiallyInlineLibCalls: Check sqrt result type before transforming it.
authorPeter Collingbourne <peter@pcc.me.uk>
Fri, 1 Aug 2014 23:21:21 +0000 (23:21 +0000)
committerPeter Collingbourne <peter@pcc.me.uk>
Fri, 1 Aug 2014 23:21:21 +0000 (23:21 +0000)
Some configure scripts declare this with the wrong prototype, which can lead
to an assertion failure.

llvm-svn: 214593

llvm/lib/Transforms/Scalar/PartiallyInlineLibCalls.cpp
llvm/test/Transforms/PartiallyInlineLibCalls/bad-prototype.ll [new file with mode: 0644]

index 7cce89e..5c8bed5 100644 (file)
@@ -108,6 +108,10 @@ bool PartiallyInlineLibCalls::optimizeSQRT(CallInst *Call,
   if (Call->onlyReadsMemory())
     return false;
 
+  // The call must have the expected result type.
+  if (!Call->getType()->isFloatingPointTy())
+    return false;
+
   // Do the following transformation:
   //
   // (before)
diff --git a/llvm/test/Transforms/PartiallyInlineLibCalls/bad-prototype.ll b/llvm/test/Transforms/PartiallyInlineLibCalls/bad-prototype.ll
new file mode 100644 (file)
index 0000000..34cd672
--- /dev/null
@@ -0,0 +1,13 @@
+; RUN: opt -S -partially-inline-libcalls < %s | FileCheck %s
+
+target triple = "x86_64-unknown-linux-gnu"
+
+declare i32 @sqrt()
+
+; CHECK-LABEL: @foo
+define i32 @foo() {
+  ; CHECK: call{{.*}}@sqrt
+  ; CHECK-NOT: call{{.*}}@sqrt
+  %r = call i32 @sqrt()
+  ret i32 %r
+}