Remove warning message and Update doxygen

Change-Id: Ie9093f8062e706b7b189a060b3fb7c5aa758c0e0
Signed-off-by: Hyun Lee <hyunn.lee@samsung.com>

diff --git a/inc/FWebBookmarkItem.h b/inc/FWebBookmarkItem.h
index 48f4cd1..0295eec 100755 (executable)
--- a/inc/FWebBookmarkItem.h
+++ b/inc/FWebBookmarkItem.h
@@ -160,7 +160,7 @@ public:
         * @param[in]   obj                             The object to compare with the current instance
         * @see Tizen::Base::Object::Equals()
         */
-       virtual bool Equals(const Object& obj) const;
+       virtual bool Equals(const Tizen::Base::Object& obj) const;
 
        /**
         * Copying of objects using this copy assignment operator is allowed. 

diff --git a/inc/FWebCtrlWebSetting.h b/inc/FWebCtrlWebSetting.h
index ae3531c..719bedf 100755 (executable)
--- a/inc/FWebCtrlWebSetting.h
+++ b/inc/FWebCtrlWebSetting.h
@@ -382,7 +382,7 @@ public:
         * @remarks             This method returns @c true if and only if the two instances contain the same elements.
         * @see                 Tizen::Base::Object::Equals()
         */
-       virtual bool Equals(const Object& obj) const;
+       virtual bool Equals(const Tizen::Base::Object& obj) const;
 
        /**
         * Copying of objects using this copy assignment operator is allowed. 

diff --git a/src/FWeb_WebBookmarkImpl.cpp b/src/FWeb_WebBookmarkImpl.cpp
index 86ddead..2b7632e 100755 (executable)
--- a/src/FWeb_WebBookmarkImpl.cpp
+++ b/src/FWeb_WebBookmarkImpl.cpp
@@ -99,8 +99,6 @@ CATCH:
 result
 _WebBookmarkImpl::AddFolder(const String& title, RecordId parentId, RecordId& folderId)
 {
-       result r = E_SUCCESS;
-
        std::unique_ptr<char[]> pTitle(_StringConverter::CopyToCharArrayN(title));
        SysTryReturn(NID_WEB, pTitle.get(), GetLastResult(), GetLastResult(), "[%s] Propagating.", GetErrorMessage(GetLastResult()));
 

diff --git a/src/controls/FWebCtrlWeb.cpp b/src/controls/FWebCtrlWeb.cpp
index 1c0ebd2..a609f08 100755 (executable)
--- a/src/controls/FWebCtrlWeb.cpp
+++ b/src/controls/FWebCtrlWeb.cpp
@@ -506,8 +506,6 @@ Web::ReleaseBlock(void)
        _WebImpl* pWebImpl = _WebImpl::GetInstance(this);
        SysAssertf(pWebImpl != null && pWebImpl->HasValidNativeNode(), "Not yet constructed or Not attached to parent control.");
 
-       result r = E_SUCCESS;
-
        pWebImpl->ReleaseBlock();
 
        return E_SUCCESS;
@@ -520,8 +518,6 @@ Web::GetBlockRange(Point& startPoint, Point& endPoint) const
        const _WebImpl* pWebImpl = _WebImpl::GetInstance(this);
        SysAssertf(pWebImpl != null && pWebImpl->HasValidNativeNode(), "Not yet constructed or Not attached to parent control.");
 
-       result r = E_SUCCESS;
-
        pWebImpl->GetBlockRange(startPoint, endPoint);
 
        return E_SUCCESS;
@@ -534,8 +530,6 @@ Web::GetBlockRange(FloatPoint& startPoint, FloatPoint& endPoint) const
        const _WebImpl* pWebImpl = _WebImpl::GetInstance(this);
        SysAssertf(pWebImpl != null && pWebImpl->HasValidNativeNode(), "Not yet constructed or Not attached to parent control.");
 
-       result r = E_SUCCESS;
-
        pWebImpl->GetBlockRange(startPoint, endPoint);
 
        return E_SUCCESS;

diff --git a/src/controls/FWebCtrlWebStorageManager.cpp b/src/controls/FWebCtrlWebStorageManager.cpp
index f0e31d8..201000d 100755 (executable)
--- a/src/controls/FWebCtrlWebStorageManager.cpp
+++ b/src/controls/FWebCtrlWebStorageManager.cpp
@@ -44,8 +44,6 @@ WebStorageManager* WebStorageManager::__pInstance = null;
 WebStorageManager::WebStorageManager(void)
        : __pWebStorageManagerImpl(null)
 {
-       result r = E_SUCCESS;
-
        std::unique_ptr<_WebStorageManagerImpl> pWebStorageManagerImpl(new (std::nothrow) _WebStorageManagerImpl());
        SysTryReturnVoidResult(NID_WEB_CTRL, pWebStorageManagerImpl.get(), E_OUT_OF_MEMORY, "[%s] Memory allocation failed.", GetErrorMessage(E_OUT_OF_MEMORY));
 

diff --git a/src/controls/FWebCtrl_AppControlListener.cpp b/src/controls/FWebCtrl_AppControlListener.cpp
index 8c0dbf3..73e0349 100755 (executable)
--- a/src/controls/FWebCtrl_AppControlListener.cpp
+++ b/src/controls/FWebCtrl_AppControlListener.cpp
@@ -54,7 +54,7 @@ _CertificateListener::OnAppControlCompleteResponseReceived(const Tizen::App::App
        {
                SysTryReturnVoidResult(NID_WEB_CTRL, pAppData, E_SYSTEM, "[E_SYSTEM] Certificate Manager AppControl failed");
 
-               String* pCertID = static_cast< String* >(const_cast< Object* >(pAppData->GetValue(String(L"Id"))));
+               //String* pCertID = static_cast< String* >(const_cast< Object* >(pAppData->GetValue(String(L"Id"))));
                // TODO : test if the result of Certificate AppControl complies with the following
                // const char* pCertificateFile;
                // ewk_set_certificate_file(pCertificateFile);

diff --git a/src/controls/FWebCtrl_EflWebkit.cpp b/src/controls/FWebCtrl_EflWebkit.cpp
index e559c83..558aa6c 100755 (executable)
--- a/src/controls/FWebCtrl_EflWebkit.cpp
+++ b/src/controls/FWebCtrl_EflWebkit.cpp
@@ -125,7 +125,10 @@ _EflWebkit::SetWebConfiguration(void) const
        Ewk_Context* pContext = ewk_view_context_get(__pWebFrame);
        SysAssertf(pContext, "Failed to request.");
 
-       ewk_view_text_selection_enable_set(__pWebFrame, EINA_FALSE);
+       Ewk_Settings* pSettings = ewk_view_settings_get(__pWebFrame);
+       SysAssertf(pSettings, "Failed to get webkit instance.");
+
+       ewk_settings_text_selection_enabled_set(pSettings, EINA_FALSE);
 
        ewk_context_additional_plugin_path_set(pContext, PLUGIN_DIRECTORY_PATH);
 

diff --git a/src/controls/FWebCtrl_SelectBox.cpp b/src/controls/FWebCtrl_SelectBox.cpp
index 17a249c..07c172b 100755 (executable)
--- a/src/controls/FWebCtrl_SelectBox.cpp
+++ b/src/controls/FWebCtrl_SelectBox.cpp
@@ -289,7 +289,6 @@ _SelectBox::CreateItem(int index, int itemWidth)
        int listItemXPos = 0;
        int listItemYPos = 0;
        int checkBoxWidth = 0;
-       int listItemTxtHeight = 0;
        int listItemHeight = 0;
        int popupBetweenListNBtnGap = 0;
 

diff --git a/src/controls/FWebCtrl_UserConfirmPopup.cpp b/src/controls/FWebCtrl_UserConfirmPopup.cpp
index 6035a92..1407af4 100755 (executable)
--- a/src/controls/FWebCtrl_UserConfirmPopup.cpp
+++ b/src/controls/FWebCtrl_UserConfirmPopup.cpp
@@ -58,8 +58,8 @@ namespace Tizen { namespace Web { namespace Controls
 _UserConfirmPopup::_UserConfirmPopup(void)
        : __pUserPolicyData(null)
        , __userConfirmMode(USER_CONFIRM_USERMEDIA)
-       , __sync(false)
        , __pCheckButton(null)
+       , __sync(false)
 {
 }
 

diff --git a/src/controls/FWebCtrl_Web.cpp b/src/controls/FWebCtrl_Web.cpp
index 52a9ed2..efc3be8 100755 (executable)
--- a/src/controls/FWebCtrl_Web.cpp
+++ b/src/controls/FWebCtrl_Web.cpp
@@ -119,8 +119,7 @@ static const char WEB_CTRL[] = "webcontrol";
 
 
 _Web::_Web(void)
-       : __gestureType(WEB_GESTURE_TYPE_TAP)
-       , __pGestureHandler(null)
+       : __pGestureHandler(null)
        , __pEflWebkit(null)
        , __pWebSetting(null)
        , __pGestureFlick(null)
@@ -132,6 +131,8 @@ _Web::_Web(void)
        , __pPanningGestureHandler(null)
        , __pFlickGestureHandler(null)
        , __pPinchGestureHandler(null)
+       , __gestureType(WEB_GESTURE_TYPE_TAP)
+       , __pTextElement(null)
 {
        SetBackgroundColor(Color(0, 0, 0, 0));
 }
@@ -301,6 +302,19 @@ _Web::InitializeWebNativeNode(void)
        _AccessibilityContainer* pContainer = GetAccessibilityContainer();
        SysTryReturn(NID_WEB_CTRL, pContainer, E_SYSTEM, E_SYSTEM, "[%s] Propagating.", GetErrorMessage(E_SYSTEM));
 
+       if (pContainer)
+       {
+               __pTextElement = new (std::nothrow) _AccessibilityElement(true);
+               SysTryReturn(NID_WEB_CTRL, __pTextElement, E_OUT_OF_MEMORY, E_OUT_OF_MEMORY, "[%s] Memory shortage.", GetErrorMessage(E_OUT_OF_MEMORY));
+
+               __pTextElement->SetBounds(FloatRectangle(0.0f, 0.0f, GetBoundsF().width, GetBoundsF().height));
+               //__pTextElement->SetLabel(GetText());
+               //__pTextElement->SetTrait(L"Web");
+               //__pTextElement->SetName(L"WebText");
+
+               pContainer->AddElement(*__pTextElement);
+       }
+
        pContainer->Activate(true);
        _WebAccessibilityFocusHandler* pFocusHandler = new (std::nothrow) _WebAccessibilityFocusHandler();
        pContainer->SetFocusHandler(dynamic_cast<_IAccessibilityFocusHandler*>(pFocusHandler));

diff --git a/src/controls/FWebCtrl_Web.h b/src/controls/FWebCtrl_Web.h
index db2f32e..23d118f 100755 (executable)
--- a/src/controls/FWebCtrl_Web.h
+++ b/src/controls/FWebCtrl_Web.h
@@ -35,6 +35,7 @@
 
 namespace Tizen { namespace Ui
 {
+class _AccessibilityElement;
 class _TouchInfo;
 }} // Tizen::Ui
 
@@ -176,6 +177,8 @@ private:
        std::unique_ptr<_PinchGestureState> __pPinchGestureHandler;
 
        _WebGestureType __gestureType;
+
+       Tizen::Ui::_AccessibilityElement* __pTextElement;
 }; // _Web
 
 }}} // Tizen::Web::Controls

diff --git a/src/controls/FWebCtrl_WebImpl.cpp b/src/controls/FWebCtrl_WebImpl.cpp
index e88ea04..218f83b 100755 (executable)
--- a/src/controls/FWebCtrl_WebImpl.cpp
+++ b/src/controls/FWebCtrl_WebImpl.cpp
@@ -4019,8 +4019,6 @@ _WebImpl::OnHandleWebDownloadEvent(const IEventArg& arg)
 result
 _WebImpl::OnHandleWebUiEvent(const IEventArg& arg)
 {
-       result r = E_SUCCESS;
-
        const _WebUiEventArg* pEventArg = dynamic_cast< const _WebUiEventArg* >(&arg);
        SysTryReturnResult(NID_WEB_CTRL, pEventArg, E_INVALID_ARG, "Invalid argument(s) is used. Type casting failed. argument must be IEventArg type.");
 
@@ -4084,8 +4082,6 @@ _WebImpl::OnHandleWebUiEvent(const IEventArg& arg)
 result
 _WebImpl::OnHandleWebUiEventF(const IEventArg& arg)
 {
-       result r = E_SUCCESS;
-
        const _WebUiEventArg* pEventArg = dynamic_cast< const _WebUiEventArg* >(&arg);
        SysTryReturnResult(NID_WEB_CTRL, pEventArg, E_INVALID_ARG, "Invalid argument(s) is used. Type casting failed. argument must be IEventArg type.");
 

diff --git a/src/controls/FWebCtrl_WebImpl.h b/src/controls/FWebCtrl_WebImpl.h
index 3253c16..51ecc49 100755 (executable)
--- a/src/controls/FWebCtrl_WebImpl.h
+++ b/src/controls/FWebCtrl_WebImpl.h
@@ -124,7 +124,6 @@ class _WebImpl
        : public Tizen::Ui::_ContainerImpl
        , public Tizen::Ui::ITextEventListener
        , public Tizen::Web::Controls::_IWebEventListener
-       , virtual public Tizen::Base::Runtime::IEventListener
 {
 public:
        _WebImpl(Web* pWeb, Tizen::Ui::_Control* pCore);

diff --git a/src/controls/FWebCtrl_WebStorageManagerImpl.cpp b/src/controls/FWebCtrl_WebStorageManagerImpl.cpp
index 3fd9552..b16f2de 100755 (executable)
--- a/src/controls/FWebCtrl_WebStorageManagerImpl.cpp
+++ b/src/controls/FWebCtrl_WebStorageManagerImpl.cpp
@@ -80,7 +80,7 @@ _WebStorageManagerImpl::GetOriginListN(WebStorageType storageType)
        result r = E_SUCCESS;
 
        Ewk_Context* pDefaultContext = ewk_context_default_get();
-       Eina_List* pOriginEinaList;
+       Eina_List* pOriginEinaList = null;
 
        _WebPresenter presenter;
        presenter.InitAsyncProcess();
@@ -301,7 +301,7 @@ _WebStorageManagerImpl::CompareOrigin(WebStorageType storageType, const String&
 {
        Ewk_Context* pDefaultContext = ewk_context_default_get();
        _WebPresenter presenter;
-       Eina_List* pOriginList;
+       Eina_List* pOriginList = null;
        presenter.InitAsyncProcess();
 
        switch (storageType)