modesetting-101: Only store property value when set_property was successful.
authorMaarten Maathuis <madman2003@gmail.com>
Sun, 20 Jul 2008 12:58:46 +0000 (14:58 +0200)
committerMaarten Maathuis <madman2003@gmail.com>
Sun, 20 Jul 2008 12:58:46 +0000 (14:58 +0200)
linux-core/drm_crtc.c

index c984209..91bff1f 100644 (file)
@@ -2184,12 +2184,12 @@ int drm_mode_connector_property_set_ioctl(struct drm_device *dev,
                }
        }
 
-       /* store the property value */
-       drm_connector_property_set_value(connector, property, out_resp->value);
-
        if (connector->funcs->set_property)
                ret = connector->funcs->set_property(connector, property, out_resp->value);
 
+       /* store the property value if succesful */
+       if (!ret)
+               drm_connector_property_set_value(connector, property, out_resp->value);
 out:
        mutex_unlock(&dev->mode_config.mutex);
        return ret;