drivers: nfc: nfcsim: remove return value check of `dev_dir`
authorJianuo Kuang <u202110722@hust.edu.cn>
Mon, 24 Apr 2023 02:41:40 +0000 (10:41 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Apr 2023 01:12:42 +0000 (18:12 -0700)
Smatch complains that:
nfcsim_debugfs_init_dev() warn: 'dev_dir' is an error pointer or valid

According to the documentation of the debugfs_create_dir() function,
there is no need to check the return value of this function.
Just delete the dead code.

Signed-off-by: Jianuo Kuang <u202110722@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20230424024140.34607-1-u202110722@hust.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/nfcsim.c

index 85bf8d5..44eeb17 100644 (file)
@@ -367,11 +367,6 @@ static void nfcsim_debugfs_init_dev(struct nfcsim *dev)
        }
 
        dev_dir = debugfs_create_dir(devname, nfcsim_debugfs_root);
-       if (!dev_dir) {
-               NFCSIM_ERR(dev, "Could not create debugfs entries for nfc%d\n",
-                          idx);
-               return;
-       }
 
        debugfs_create_u8("dropframe", 0664, dev_dir, &dev->dropframe);
 }