greybus: operation: print id when synchronous operation timeout
authorDavid Lin <dtwlin@google.com>
Fri, 22 Jul 2016 20:46:25 +0000 (13:46 -0700)
committerGreg Kroah-Hartman <gregkh@google.com>
Fri, 22 Jul 2016 20:57:11 +0000 (13:57 -0700)
In case of a synchronous operation timeout error, it's helpful for
purpose of debugging to print the operation id in the error message, so
that we know if the response is received at a later time after operation
time out.

Testing Done:
 - Observe the error message below when response comes later after
operation timeout:

[  792.973978] greybus greybus1: 0/0:0: synchronous operation id 0x0005
of type 0x21 failed: -110
[  800.646694] greybus greybus1: 0/0:0: unexpected response id 0x0005
received

Signed-off-by: David Lin <dtwlin@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/operation.c

index 659e84b..7475ec7 100644 (file)
@@ -1128,8 +1128,8 @@ int gb_operation_sync_timeout(struct gb_connection *connection, int type,
        ret = gb_operation_request_send_sync_timeout(operation, timeout);
        if (ret) {
                dev_err(&connection->hd->dev,
-                       "%s: synchronous operation of type 0x%02x failed: %d\n",
-                       connection->name, type, ret);
+                       "%s: synchronous operation id 0x%04x of type 0x%02x failed: %d\n",
+                       connection->name, operation->id, type, ret);
        } else {
                if (response_size) {
                        memcpy(response, operation->response->payload,