linux-user: improve flatload error checking
authorBlue Swirl <blauwirbel@gmail.com>
Sat, 18 Sep 2010 05:53:14 +0000 (05:53 +0000)
committerBlue Swirl <blauwirbel@gmail.com>
Sat, 18 Sep 2010 05:53:14 +0000 (05:53 +0000)
Because of the use of unsigned type, possible errors during
load were ignored.

Fix by using a signed type.

This also avoids a warning with GCC flag -Wtype-limits.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
linux-user/flatload.c

index 8ad130a..8f9f4a5 100644 (file)
@@ -383,7 +383,8 @@ static int load_flat_file(struct linux_binprm * bprm,
                struct lib_info *libinfo, int id, abi_ulong *extra_stack)
 {
     struct flat_hdr * hdr;
-    abi_ulong textpos = 0, datapos = 0, result;
+    abi_ulong textpos = 0, datapos = 0;
+    abi_long result;
     abi_ulong realdatastart = 0;
     abi_ulong text_len, data_len, bss_len, stack_len, flags;
     abi_ulong memp = 0; /* for finding the brk area */