// RUN: %check_clang_tidy -std=c++11,c++14 %s readability-redundant-string-init %t \
// RUN: -config="{CheckOptions: \
// RUN: [{key: readability-redundant-string-init.StringNames, \
-// RUN: value: '::std::basic_string;our::TestString'}] \
+// RUN: value: '::std::basic_string;::std::basic_string_view;our::TestString'}] \
// RUN: }"
// FIXME: Fix the checker to work in C++17 mode.
};
typedef basic_string<char> string;
typedef basic_string<wchar_t> wstring;
+
+template <typename C, typename T = std::char_traits<C>, typename A = std::allocator<C>>
+struct basic_string_view {
+ using size_type = decltype(sizeof(0));
+
+ basic_string_view();
+ basic_string_view(const basic_string_view &);
+ basic_string_view(const C *, size_type);
+ basic_string_view(const C *);
+ template <class It, class End>
+ basic_string_view(It, End);
+};
+typedef basic_string_view<char> string_view;
+typedef basic_string_view<wchar_t> wstring_view;
}
void f() {
std::string z;
}
+void fview() {
+ std::string_view a = "";
+ // CHECK-MESSAGES: [[@LINE-1]]:20: warning: redundant string initialization [readability-redundant-string-init]
+ // CHECK-FIXES: std::string_view a;
+ std::string_view b("");
+ // CHECK-MESSAGES: [[@LINE-1]]:20: warning: redundant string initialization
+ // CHECK-FIXES: std::string_view b;
+ std::string_view c = R"()";
+ // CHECK-MESSAGES: [[@LINE-1]]:20: warning: redundant string initialization
+ // CHECK-FIXES: std::string_view c;
+ std::string_view d(R"()");
+ // CHECK-MESSAGES: [[@LINE-1]]:20: warning: redundant string initialization
+ // CHECK-FIXES: std::string_view d;
+ std::string_view e{""};
+ // CHECK-MESSAGES: [[@LINE-1]]:20: warning: redundant string initialization
+ // CHECK-FIXES: std::string_view e;
+ std::string_view f = {""};
+ // CHECK-MESSAGES: [[@LINE-1]]:20: warning: redundant string initialization
+ // CHECK-FIXES: std::string_view f;
+
+ std::string_view u = "u";
+ std::string_view w("w");
+ std::string_view x = R"(x)";
+ std::string_view y(R"(y)");
+ std::string_view z;
+}
+
void g() {
std::wstring a = L"";
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
std::wstring z;
}
+void gview() {
+ std::wstring_view a = L"";
+ // CHECK-MESSAGES: [[@LINE-1]]:21: warning: redundant string initialization [readability-redundant-string-init]
+ // CHECK-FIXES: std::wstring_view a;
+ std::wstring_view b(L"");
+ // CHECK-MESSAGES: [[@LINE-1]]:21: warning: redundant string initialization
+ // CHECK-FIXES: std::wstring_view b;
+ std::wstring_view c = L"";
+ // CHECK-MESSAGES: [[@LINE-1]]:21: warning: redundant string initialization
+ // CHECK-FIXES: std::wstring_view c;
+ std::wstring_view d(L"");
+ // CHECK-MESSAGES: [[@LINE-1]]:21: warning: redundant string initialization
+ // CHECK-FIXES: std::wstring_view d;
+ std::wstring_view e{L""};
+ // CHECK-MESSAGES: [[@LINE-1]]:21: warning: redundant string initialization
+ // CHECK-FIXES: std::wstring_view e;
+ std::wstring_view f = {L""};
+ // CHECK-MESSAGES: [[@LINE-1]]:21: warning: redundant string initialization
+ // CHECK-FIXES: std::wstring_view f;
+
+ std::wstring_view u = L"u";
+ std::wstring_view w(L"w");
+ std::wstring_view x = LR"(x)";
+ std::wstring_view y(LR"(y)");
+ std::wstring_view z;
+}
+
template <typename T>
void templ() {
std::string s = "";
// CHECK-MESSAGES: [[@LINE-2]]:23: warning: redundant string initialization
// CHECK-FIXES: Foo(float) {}
-
// Check how it handles removing some redundant initializers while leaving
// valid initializers intact.
Foo(std::string Arg) : A(Arg), B(""), C("NonEmpty"), D(R"()"), E("") {}