Fix SVACE warnings

- fix 11 svace warnings

Change-Id: If54d2cc0ea5eccd069e069526c8b75e9ecd7a4a5
Signed-off-by: kiseok chang <kiso.chang@samsung.com>

diff --git a/setting-appmgr/src/setting-appmgr-pkginfo-utils.c b/setting-appmgr/src/setting-appmgr-pkginfo-utils.c
index 763cbe91766fd3fc73929cf0cb9358404fad91ed..e6f7db1123ea64c6abf20606c148df8914f00522 100644 (file)
--- a/setting-appmgr/src/setting-appmgr-pkginfo-utils.c
+++ b/setting-appmgr/src/setting-appmgr-pkginfo-utils.c
@@ -345,28 +345,6 @@ static UNUSED int _appmgrUg_pkg_get_pkg_size(int req_id, const char *pkg_type,
        return 0;
 }
 
-static inline void appmgrUg_pkg_get_pkg_size(appmgr_pkginfo *info)
-{
-       int ret;
-
-       ret_if(NULL == info);
-
-       if (info->pc_size)
-               pkgmgr_client_free(info->pc_size);
-
-       info->pc_size = pkgmgr_client_new(PC_REQUEST);
-       if (NULL == info->pc_size) {
-               SETTING_TRACE_ERROR("pkgmgr_client_new() Fail");
-               return;
-       }
-       /*
-        @FIX ME add correct callback handler for this pkgmgr call
-        ret = pkgmgr_client_get_size(info->pc_size, info->pkgid,
-        PM_GET_TOTAL_SIZE,
-        NULL, info);
-        */
-       warn_if(ret, "pkgmgr_client_get_size(%s) Fail(%d)", info->pkgid, ret);
-}
 
 static void _get_cache_cb(const char *package_id,
                const package_size_info_h size_info, void *data)

diff --git a/setting-display/src/setting-display-main.c b/setting-display/src/setting-display-main.c
index c47898bc665c73028f73040649b26cca7e118779..d7e72da8e76ab83a3c4b30a482c972742b2626f4 100644 (file)
--- a/setting-display/src/setting-display-main.c
+++ b/setting-display/src/setting-display-main.c
@@ -195,11 +195,13 @@ static void setting_display_screen_timeout_popup(void *data)
        if (ad->data_backlight_always_on) {
                ad->data_backlight_always_on->userdata = ad;
                __BACK_POINTER_SET(ad->data_backlight_always_on);
+
+
+               _pdm_handle(0, max_inactivity_time, ad->data_backlight_always_on);
        } else {
                SETTING_TRACE_ERROR("ad->data_backlight_always_on is NULL");
        }
 
-       _pdm_handle(0, max_inactivity_time, ad->data_backlight_always_on);
        radio_num++;
 
        ad->data_backlight_15sec = setting_create_Gendial_field_1radio(
@@ -211,10 +213,12 @@ static void setting_display_screen_timeout_popup(void *data)
        if (ad->data_backlight_15sec) {
                ad->data_backlight_15sec->userdata = ad;
                __BACK_POINTER_SET(ad->data_backlight_15sec);
+
+               _pdm_handle(1, max_inactivity_time, ad->data_backlight_15sec);
        } else {
                SETTING_TRACE_ERROR("ad->data_backlight_15sec is NULL");
        }
-       _pdm_handle(1, max_inactivity_time, ad->data_backlight_15sec);
+
        radio_num++;
 
        ad->data_backlight_30sec = setting_create_Gendial_field_1radio(
@@ -226,10 +230,11 @@ static void setting_display_screen_timeout_popup(void *data)
        if (ad->data_backlight_30sec) {
                ad->data_backlight_30sec->userdata = ad;
                __BACK_POINTER_SET(ad->data_backlight_30sec);
+
+               _pdm_handle(2, max_inactivity_time, ad->data_backlight_30sec);
        } else {
                SETTING_TRACE_ERROR("ad->data_backlight_30sec is NULL");
        }
-       _pdm_handle(2, max_inactivity_time, ad->data_backlight_30sec);
        radio_num++;
 
        ad->data_backlight_1min = setting_create_Gendial_field_1radio(
@@ -241,10 +246,12 @@ static void setting_display_screen_timeout_popup(void *data)
        if (ad->data_backlight_1min) {
                ad->data_backlight_1min->userdata = ad;
                __BACK_POINTER_SET(ad->data_backlight_1min);
-       } else {
+
+               _pdm_handle(3, max_inactivity_time, ad->data_backlight_1min);
+} else {
                SETTING_TRACE_ERROR("ad->data_backlight_1min is NULL");
        }
-       _pdm_handle(3, max_inactivity_time, ad->data_backlight_1min);
+       
        radio_num++;
 
        ad->data_backlight_2min = setting_create_Gendial_field_1radio(
@@ -256,10 +263,12 @@ static void setting_display_screen_timeout_popup(void *data)
        if (ad->data_backlight_2min) {
                ad->data_backlight_2min->userdata = ad;
                __BACK_POINTER_SET(ad->data_backlight_2min);
+
+               _pdm_handle(4, max_inactivity_time, ad->data_backlight_2min);
        } else {
                SETTING_TRACE_ERROR("ad->data_backlight_2min is NULL");
        }
-       _pdm_handle(4, max_inactivity_time, ad->data_backlight_2min);
+       
        radio_num++;
 
        ad->data_backlight_5min = setting_create_Gendial_field_1radio(
@@ -271,10 +280,12 @@ static void setting_display_screen_timeout_popup(void *data)
        if (ad->data_backlight_5min) {
                ad->data_backlight_5min->userdata = ad;
                __BACK_POINTER_SET(ad->data_backlight_5min);
+
+
+               _pdm_handle(5, max_inactivity_time, ad->data_backlight_5min);
        } else {
                SETTING_TRACE_ERROR("ad->data_backlight_5min is NULL");
        }
-       _pdm_handle(5, max_inactivity_time, ad->data_backlight_5min);
        radio_num++;
 
        ad->data_backlight_10min = setting_create_Gendial_field_1radio(
@@ -286,10 +297,12 @@ static void setting_display_screen_timeout_popup(void *data)
        if (ad->data_backlight_10min) {
                ad->data_backlight_10min->userdata = ad;
                __BACK_POINTER_SET(ad->data_backlight_10min);
+
+               _pdm_handle(6, max_inactivity_time, ad->data_backlight_10min);
        } else {
                SETTING_TRACE_ERROR("ad->data_backlight_10min is NULL");
        }
-       _pdm_handle(6, max_inactivity_time, ad->data_backlight_10min);
+
        radio_num++;
 
        /* update radio */

diff --git a/setting-network/src/setting-network-connection-create.c b/setting-network/src/setting-network-connection-create.c
index 22a572efce6aeb12ae01a8b70eb9458f0bc0d3b7..1a5831b092b1fc202ee59f3df54c1f6aa02171a1 100644 (file)
--- a/setting-network/src/setting-network-connection-create.c
+++ b/setting-network/src/setting-network-connection-create.c
@@ -1199,11 +1199,13 @@ static int setting_network_connection_create(void *cb)
        if (ad->data_auth_type) {
                ad->data_auth_type->userdata = ad;
                __BACK_POINTER_SET(ad->data_auth_type);
+
+               ad->item_above_user_name = ad->data_auth_type->item;
        } else {
                SETTING_TRACE_ERROR("ad->data_auth_type is NULL");
        }
 
-       ad->item_above_user_name = ad->data_auth_type->item;
+       
        ad->is_show_user = 0;
        if (CONNECTION_CELLULAR_AUTH_TYPE_NONE != ad->chkType) {
                /* [UI] User ID */
@@ -1253,11 +1255,13 @@ static int setting_network_connection_create(void *cb)
                        ad->data_pwd->win_main = ad->win_get;
                        ad->data_pwd->isSinglelineFlag = TRUE;
                        ad->is_show_user = 1;
+
+                       ad->item_above_proxy_add = ad->data_pwd->item;
                } else {
                        SETTING_TRACE_ERROR("ad->data_pwd is NULL");
                }
 
-               ad->item_above_proxy_add = ad->data_pwd->item;
+               
        }
 
        /* [UI] Proxy address */

diff --git a/setting-profile/src/setting-profile-sound-main.c b/setting-profile/src/setting-profile-sound-main.c
index 179226e02a22328182b4e8cd61bd665d1ca4e0cc..77f691e360c89e548e0bed6a9502f18099d851c9 100644 (file)
--- a/setting-profile/src/setting-profile-sound-main.c
+++ b/setting-profile/src/setting-profile-sound-main.c
@@ -657,6 +657,8 @@ static void __get_lite_main_list(void *data)
        ret_if(!data);
        SettingProfileUG *ad = (SettingProfileUG *)data;
 
+
+
        int vconf_value = 0;
        char *sub_desc = NULL;
        char *left_icon = NULL;
@@ -787,7 +789,8 @@ static void __get_lite_main_list(void *data)
        __BACK_POINTER_SET(ad->data_call_volume);
 
        /* Disable Call Volume slider if Silent ringtone is selected */
-       if( !safeStrCmp(ad->data_call_alert_tone->sub_desc, "Silent")){
+       if(ad->data_call_volume && ad->data_call_alert_tone &&
+                       !safeStrCmp(ad->data_call_alert_tone->sub_desc, "Silent")){
                elm_object_item_disabled_set(ad->data_call_volume->item, EINA_TRUE);
                elm_object_disabled_set(ad->data_call_volume->eo_check, EINA_TRUE);
        }
@@ -851,7 +854,8 @@ static void __get_lite_main_list(void *data)
        __BACK_POINTER_SET(ad->data_noti_volume);
 
        /* Disable Notification slider if Silent ringtone is selected */
-       if( !safeStrCmp(ad->data_msg_alert_tone->sub_desc, "Silent")){
+       if( ad->data_noti_volume && ad->data_msg_alert_tone &&
+                               !safeStrCmp(ad->data_msg_alert_tone->sub_desc, "Silent")){
                elm_object_item_disabled_set(ad->data_noti_volume->item, EINA_TRUE);
                elm_object_disabled_set(ad->data_noti_volume->eo_check, EINA_TRUE);
        }