block: remove BIO_PAGE_REFFED
authorChristoph Hellwig <hch@lst.de>
Wed, 14 Jun 2023 14:03:40 +0000 (16:03 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 16 Jun 2023 16:08:09 +0000 (10:08 -0600)
Now that all block direct I/O helpers use page pinning, this flag is
unused.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20230614140341.521331-4-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk.h
include/linux/bio.h
include/linux/blk_types.h

index 768852a..608c5dc 100644 (file)
@@ -445,8 +445,6 @@ static inline void bio_release_page(struct bio *bio, struct page *page)
 {
        if (bio_flagged(bio, BIO_PAGE_PINNED))
                unpin_user_page(page);
-       else if (bio_flagged(bio, BIO_PAGE_REFFED))
-               put_page(page);
 }
 
 struct request_queue *blk_alloc_queue(int node_id);
index 6175229..c4f5b52 100644 (file)
@@ -492,8 +492,7 @@ void zero_fill_bio(struct bio *bio);
 
 static inline void bio_release_pages(struct bio *bio, bool mark_dirty)
 {
-       if (bio_flagged(bio, BIO_PAGE_REFFED) ||
-           bio_flagged(bio, BIO_PAGE_PINNED))
+       if (bio_flagged(bio, BIO_PAGE_PINNED))
                __bio_release_pages(bio, mark_dirty);
 }
 
index deb69ee..752a54e 100644 (file)
@@ -326,7 +326,6 @@ struct bio {
  */
 enum {
        BIO_PAGE_PINNED,        /* Unpin pages in bio_release_pages() */
-       BIO_PAGE_REFFED,        /* put pages in bio_release_pages() */
        BIO_CLONED,             /* doesn't own data */
        BIO_BOUNCED,            /* bio is a bounce bio */
        BIO_QUIET,              /* Make BIO Quiet */