crypto: qce - fix error return code in qce_skcipher_async_req_handle()

commit a8bc4f5e7a72e4067f5afd7e98b61624231713ca upstream.

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 1339a7c3ba05 ("crypto: qce: skcipher: Fix incorrect sg count for dma transfers")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c
index 5a6559131eac2e36e7b58555fd8dc27d325879bc..d8053789c8828a6dc6ac0e0a02ead50e3eacc248 100644 (file)
--- a/drivers/crypto/qce/skcipher.c
+++ b/drivers/crypto/qce/skcipher.c
@@ -123,13 +123,17 @@ qce_skcipher_async_req_handle(struct crypto_async_request *async_req)
        rctx->dst_sg = rctx->dst_tbl.sgl;
 
        dst_nents = dma_map_sg(qce->dev, rctx->dst_sg, rctx->dst_nents, dir_dst);
-       if (dst_nents < 0)
+       if (dst_nents < 0) {
+               ret = dst_nents;
                goto error_free;
+       }
 
        if (diff_dst) {
                src_nents = dma_map_sg(qce->dev, req->src, rctx->src_nents, dir_src);
-               if (src_nents < 0)
+               if (src_nents < 0) {
+                       ret = src_nents;
                        goto error_unmap_dst;
+               }
                rctx->src_sg = req->src;
        } else {
                rctx->src_sg = rctx->dst_sg;