projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
58d4704
)
i3c: Fix potential refcount leak in i3c_master_register_new_i3c_devs
author
Dinghao Liu
<dinghao.liu@zju.edu.cn>
Thu, 21 Sep 2023 08:24:10 +0000
(16:24 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:59:29 +0000
(11:59 +0100)
[ Upstream commit
cab63f64887616e3c4e31cfd8103320be6ebc8d3
]
put_device() needs to be called on failure of device_register()
to give up the reference initialized in it to avoid refcount leak.
Fixes:
3a379bbcea0a
("i3c: Add core I3C infrastructure")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link:
https://lore.kernel.org/r/20230921082410.25548-1-dinghao.liu@zju.edu.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i3c/master.c
patch
|
blob
|
history
diff --git
a/drivers/i3c/master.c
b/drivers/i3c/master.c
index
87283e4
..
0e9ff55
100644
(file)
--- a/
drivers/i3c/master.c
+++ b/
drivers/i3c/master.c
@@
-1525,9
+1525,11
@@
i3c_master_register_new_i3c_devs(struct i3c_master_controller *master)
desc->dev->dev.of_node = desc->boardinfo->of_node;
ret = device_register(&desc->dev->dev);
- if (ret)
+ if (ret)
{
dev_err(&master->dev,
"Failed to add I3C device (err = %d)\n", ret);
+ put_device(&desc->dev->dev);
+ }
}
}