wifi: rtlwifi: btcoexist: fix conditions branches that are never executed
authorPeter Kosyh <pkosyh@yandex.ru>
Tue, 6 Dec 2022 10:49:19 +0000 (13:49 +0300)
committerKalle Valo <kvalo@kernel.org>
Thu, 8 Dec 2022 14:52:56 +0000 (16:52 +0200)
Commit 40ca18823515 ("rtlwifi: btcoex: 23b 1ant: fine tune for wifi not
 connected") introduced never executed branches.

Compile test only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Peter Kosyh <pkosyh@yandex.ru>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221206104919.739746-1-pkosyh@yandex.ru
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c

index 7049292..039bbed 100644 (file)
@@ -1903,7 +1903,7 @@ btc8723b1ant_action_wifi_not_conn_scan(struct btc_coexist *btcoexist)
                                                true, 32);
                        halbtc8723b1ant_coex_table_with_type(btcoexist,
                                                             NORMAL_EXEC, 4);
-               } else if (bt_link_info->a2dp_exist) {
+               } else if (bt_link_info->pan_exist) {
                        halbtc8723b1ant_ps_tdma(btcoexist, NORMAL_EXEC,
                                                true, 22);
                        halbtc8723b1ant_coex_table_with_type(btcoexist,
@@ -1964,8 +1964,7 @@ static void btc8723b1ant_action_wifi_conn_scan(struct btc_coexist *btcoexist)
                                                true, 32);
                        halbtc8723b1ant_coex_table_with_type(btcoexist,
                                                             NORMAL_EXEC, 4);
-               } else if (bt_link_info->a2dp_exist &&
-                          bt_link_info->pan_exist) {
+               } else if (bt_link_info->pan_exist) {
                        halbtc8723b1ant_ps_tdma(btcoexist, NORMAL_EXEC,
                                                true, 22);
                        halbtc8723b1ant_coex_table_with_type(btcoexist,