uio: uio_fsl_elbc_gpcm: Replace NO_IRQ by 0
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Thu, 6 Oct 2022 05:36:50 +0000 (07:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2022 17:39:19 +0000 (18:39 +0100)
NO_IRQ is used to check the return of irq_of_parse_and_map().

On some architecture NO_IRQ is 0, on other architectures it is -1.

irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.

So use 0 instead of using NO_IRQ.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/r/68ccdf51811ab26bdb452babf17ae860fa4900c2.1665034535.git.christophe.leroy@csgroup.eu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/uio/uio_fsl_elbc_gpcm.c

index 7d8eb9d..82dda79 100644 (file)
@@ -390,13 +390,13 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_device *pdev)
        info->priv = priv;
        info->name = uio_name;
        info->version = "0.0.1";
-       if (irq != NO_IRQ) {
+       if (irq) {
                if (priv->irq_handler) {
                        info->irq = irq;
                        info->irq_flags = IRQF_SHARED;
                        info->handler = priv->irq_handler;
                } else {
-                       irq = NO_IRQ;
+                       irq = 0;
                        dev_warn(priv->dev, "ignoring irq, no handler\n");
                }
        }
@@ -417,7 +417,7 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_device *pdev)
        dev_info(priv->dev,
                 "eLBC/GPCM device (%s) at 0x%llx, bank %d, irq=%d\n",
                 priv->name, (unsigned long long)res.start, priv->bank,
-                irq != NO_IRQ ? irq : -1);
+                irq ? : -1);
 
        return 0;
 out_err2: