client/socket: Fix coverity defects

Defects of UINIT and RESOURCE_LEAK are fixed.

[Version] 0.3.11

Change-Id: If7eca58dfb83d82a20a58e125c5bee86fa445e40
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit aa78adf74fb2152f29795c9a0fc5a0bb9022defd)

diff --git a/packaging/espp-service.spec b/packaging/espp-service.spec
index 4035436..ec2a78a 100644 (file)
--- a/packaging/espp-service.spec
+++ b/packaging/espp-service.spec
@@ -1,7 +1,7 @@
 Name:       espp-service
 Summary:    ESPP service package which contains client lib. and daemon binary
-Version:    0.3.10
-Release:    2
+Version:    0.3.11
+Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0
 Source0:    %{name}-%{version}.tar.gz

diff --git a/src/client/espp_service_client_socket.c b/src/client/espp_service_client_socket.c
index b8bb01a..e70c10d 100644 (file)
--- a/src/client/espp_service_client_socket.c
+++ b/src/client/espp_service_client_socket.c
@@ -32,11 +32,13 @@ do { \
 
 #define FILL_SOCKET_MSG_REQUEST(x_msg, x_request) \
 do { \
+       memset(&x_msg, 0x00, sizeof(x_msg)); \
        x_msg.request = x_request; \
 } while (0) \
 
 #define FILL_SOCKET_MSG_RET(x_msg, x_ret) \
 do { \
+       memset(&x_msg, 0x00, sizeof(x_msg)); \
        x_msg.ret = x_ret; \
 } while (0) \
 
@@ -234,10 +236,8 @@ int espp_service_client_socket_request_init_event(espp_s *espp)
        return 0;
 
 error:
-       if (espp->event_fd != -1) {
-               close(espp->event_fd);
-               espp->event_fd = -1;
-       }
+       close(fd);
+       espp->event_fd = -1;
        return -1;
 }