From: Mike McCormack <mj.mccormack@samsung.com>

ecore_config code may end up closing stdin, due to assuming 0 is a valid fd.

I know this code is deprecated, and it's being kept around "for reference".

Either:
A) this bug should still be fixed so bad code is not copied elsewhere

OR

B) ecore_config should be deleted so bad code is not copied elsewhere

thanks,

Mike

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@56275 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

diff --git a/src/lib/ecore_config/ecore_config.c b/src/lib/ecore_config/ecore_config.c
index ddfc64f..d8b587e 100644 (file)
--- a/src/lib/ecore_config/ecore_config.c
+++ b/src/lib/ecore_config/ecore_config.c
@@ -1636,7 +1636,7 @@ ecore_config_init_global(const char *name)
        snprintf(buf, PATH_MAX, "%s/.ecore/%s/.global", p, name);
        global = creat(buf, S_IRWXU);
 
-       if (global)
+       if (global >= 0)
           close(global);
 
        free(buf);