SUNRPC: _copy_to/from_pages() now check for zero length
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sun, 6 Dec 2020 17:41:41 +0000 (12:41 -0500)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 14 Dec 2020 11:51:07 +0000 (06:51 -0500)
Clean up callers of _copy_to/from_pages() that still check for a zero
length.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
net/sunrpc/xdr.c

index 19eaa38..01918e6 100644 (file)
@@ -1665,8 +1665,7 @@ static void __read_bytes_from_xdr_buf(struct xdr_buf *subbuf, void *obj, unsigne
        len -= this_len;
        obj += this_len;
        this_len = min_t(unsigned int, len, subbuf->page_len);
-       if (this_len)
-               _copy_from_pages(obj, subbuf->pages, subbuf->page_base, this_len);
+       _copy_from_pages(obj, subbuf->pages, subbuf->page_base, this_len);
        len -= this_len;
        obj += this_len;
        this_len = min_t(unsigned int, len, subbuf->tail[0].iov_len);
@@ -1696,8 +1695,7 @@ static void __write_bytes_to_xdr_buf(struct xdr_buf *subbuf, void *obj, unsigned
        len -= this_len;
        obj += this_len;
        this_len = min_t(unsigned int, len, subbuf->page_len);
-       if (this_len)
-               _copy_to_pages(subbuf->pages, subbuf->page_base, obj, this_len);
+       _copy_to_pages(subbuf->pages, subbuf->page_base, obj, this_len);
        len -= this_len;
        obj += this_len;
        this_len = min_t(unsigned int, len, subbuf->tail[0].iov_len);