Implement isSharing() and isValid() methods for QCocoaGLContext

Shared resources may have been used when initializing NSOpenGLContext
but QCocoaGLContext did not implement isSharing(). This caused
default implementation to return false always and therefore shared
resource test case failed.

Implemented also another missing method, isValid().

Task-number: QTBUG-23061

Change-Id: Ia912450035b584ea90a02a7d88d6ae531c3cbadf
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>

diff --git a/src/plugins/platforms/cocoa/qcocoaglcontext.h b/src/plugins/platforms/cocoa/qcocoaglcontext.h
index b858202..4f80511 100644 (file)
--- a/src/plugins/platforms/cocoa/qcocoaglcontext.h
+++ b/src/plugins/platforms/cocoa/qcocoaglcontext.h
@@ -71,10 +71,14 @@ public:
     static NSOpenGLPixelFormat *createNSOpenGLPixelFormat(const QSurfaceFormat &format);
     NSOpenGLContext *nsOpenGLContext() const;
 
+    bool isSharing() const;
+    bool isValid() const;
+
 private:
     void setActiveWindow(QWindow *window);
 
     NSOpenGLContext *m_context;
+    NSOpenGLContext *m_shareContext;
     QSurfaceFormat m_format;
     QWeakPointer<QWindow> m_currentWindow;
 };

diff --git a/src/plugins/platforms/cocoa/qcocoaglcontext.mm b/src/plugins/platforms/cocoa/qcocoaglcontext.mm
index 960163d..637678c 100644 (file)
--- a/src/plugins/platforms/cocoa/qcocoaglcontext.mm
+++ b/src/plugins/platforms/cocoa/qcocoaglcontext.mm
@@ -51,13 +51,19 @@
 QCocoaGLContext::QCocoaGLContext(const QSurfaceFormat &format, QPlatformOpenGLContext *share)
     : m_format(format)
 {
-    QCocoaAutoReleasePool pool; // For the SG Canvas render thread.
+    QCocoaAutoReleasePool pool; // For the SG Canvas render thread
 
     NSOpenGLPixelFormat *pixelFormat = static_cast <NSOpenGLPixelFormat *>(qcgl_createNSOpenGLPixelFormat(format));
-    NSOpenGLContext *actualShare = share ? static_cast<QCocoaGLContext *>(share)->m_context : 0;
+    m_shareContext = share ? static_cast<QCocoaGLContext *>(share)->nsOpenGLContext() : nil;
 
     m_context = [NSOpenGLContext alloc];
-    [m_context initWithFormat:pixelFormat shareContext:actualShare];
+    [m_context initWithFormat:pixelFormat shareContext:m_shareContext];
+
+    if (!m_context && m_shareContext) {
+        // try without shared context
+        m_shareContext = nil;
+        [m_context initWithFormat:pixelFormat shareContext:nil];
+    }
 
     const GLint interval = 1;
     [m_context setValues:&interval forParameter:NSOpenGLCPSwapInterval];
@@ -139,3 +145,12 @@ NSOpenGLContext *QCocoaGLContext::nsOpenGLContext() const
     return m_context;
 }
 
+bool QCocoaGLContext::isValid() const
+{
+    return m_context != nil;
+}
+
+bool QCocoaGLContext::isSharing() const
+{
+    return m_shareContext != nil;
+}