Remove NativeWindow::ActivateContents

diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc
index dd05988..ef49218 100644 (file)
--- a/atom/browser/api/atom_api_web_contents.cc
+++ b/atom/browser/api/atom_api_web_contents.cc
@@ -267,8 +267,7 @@ void WebContents::CloseContents(content::WebContents* source) {
 }
 
 void WebContents::ActivateContents(content::WebContents* source) {
-  if (type_ == BROWSER_WINDOW)
-    owner_window()->CloseContents(source);
+  Emit("activate");
 }
 
 bool WebContents::IsPopupOrPanel(const content::WebContents* source) const {

diff --git a/atom/browser/api/lib/browser-window.coffee b/atom/browser/api/lib/browser-window.coffee
index 24ae7b8..4305b29 100644 (file)
--- a/atom/browser/api/lib/browser-window.coffee
+++ b/atom/browser/api/lib/browser-window.coffee
@@ -20,6 +20,11 @@ BrowserWindow::_init = ->
   @webContents.on 'move', (event, size) =>
     @setSize size
 
+  # Hide the auto-hide menu when webContents is focused.
+  @webContents.on 'activate', =>
+    if process.platform isnt 'darwin' and @isMenuBarAutoHide() and @isMenuBarVisible()
+      @setMenuBarVisibility false
+
   # Redirect focus/blur event to app instance too.
   @on 'blur', (event) =>
     app.emit 'browser-window-blur', event, this

diff --git a/atom/browser/native_window.h b/atom/browser/native_window.h
index c52a1e0..cc14d7b 100644 (file)
--- a/atom/browser/native_window.h
+++ b/atom/browser/native_window.h
@@ -178,7 +178,6 @@ class NativeWindow : public content::WebContentsObserver,
   virtual void CloseContents(content::WebContents* source);
   virtual void RendererUnresponsive(content::WebContents* source);
   virtual void RendererResponsive(content::WebContents* source);
-  virtual void ActivateContents(content::WebContents* contents) {}
   virtual void HandleKeyboardEvent(
       content::WebContents*,
       const content::NativeWebKeyboardEvent& event) {}

diff --git a/atom/browser/native_window_views.cc b/atom/browser/native_window_views.cc
index e0e276f..b4f5118 100644 (file)
--- a/atom/browser/native_window_views.cc
+++ b/atom/browser/native_window_views.cc
@@ -872,13 +872,6 @@ void NativeWindowViews::GetDevToolsWindowWMClass(
 }
 #endif
 
-void NativeWindowViews::ActivateContents(content::WebContents* contents) {
-  NativeWindow::ActivateContents(contents);
-  // Hide menu bar when web view is clicked.
-  if (menu_bar_autohide_ && menu_bar_visible_)
-    SetMenuBarVisibility(false);
-}
-
 void NativeWindowViews::HandleKeyboardEvent(
     content::WebContents*,
     const content::NativeWebKeyboardEvent& event) {

diff --git a/atom/browser/native_window_views.h b/atom/browser/native_window_views.h
index fe4e8a8..fa7e13c 100644 (file)
--- a/atom/browser/native_window_views.h
+++ b/atom/browser/native_window_views.h
@@ -128,7 +128,6 @@ class NativeWindowViews : public NativeWindow,
 #endif
 
   // NativeWindow:
-  void ActivateContents(content::WebContents* contents) override;
   void HandleKeyboardEvent(
       content::WebContents*,
       const content::NativeWebKeyboardEvent& event) override;